| Summary: | build-git-snapshot: add basetgz parameter and update master version number | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mirko Tietgen <mirko> |
| Component: | Packaging | Assignee: | Mirko Tietgen <mirko> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, kyle, mirko |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number
Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number [PASSED QA] Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number |
||
|
Description
Mirko Tietgen
2016-08-01 15:17:26 UTC
Created attachment 53842 [details] [review] Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. Created attachment 53869 [details] [review] Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> *** Bug 16676 has been marked as a duplicate of this bug. *** Comment on attachment 53869 [details] [review] Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number Review of attachment 53869 [details] [review]: ----------------------------------------------------------------- ::: debian/build-git-snapshot @@ +31,4 @@ > my $buildresult; > my $distribution='squeeze-dev'; > my $git_checks='all'; > +my $version='16.06~git'; Should not we create a subroutine to guess the version? Otherwise we will have to update it every 6 months :) (In reply to Jonathan Druart from comment #4) > Should not we create a subroutine to guess the version? > Otherwise we will have to update it every 6 months :) I think we did something similar in some other place. Do you remember where? Waiting for feedback from Mirko. Katrin: You're right, but it does not really appy here. Also I override the version anyway. I think changing this to a more intelligent setting should be a seperate patch, I need the basetgz part now. Trusting Mirko here. Created attachment 54125 [details] [review] [PASSED QA] Bug 17013 - build-git-snapshot: add basetgz parameter and update master version number This adds a basetgz parameter to specify a pbuilder image. I use this to build against different distributions. This also updates the version number for master builds to 16.06. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Mirko! Thanks Kyle! Frederic: Can you push this to 16.05 please? I need it for the nightly builds. Pushed in 16.05. Will be in 16.05.03. |