Bug 17236

Summary: Add minute and hours to last checked out item display for hourly loans
Product: Koha Reporter: Nick Clemens <nick>
Component: CirculationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, josef.moravec, katrin.fischer, kyle.m.hall, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 22375    
Attachments: Bug 17236: Add minute an dhours to last checked out item on circulation for hourly loans
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans

Description Nick Clemens 2016-09-02 00:56:46 UTC
bug 13315 added a display of the last item checked out. Some libraries use this feature and also use hourly loans and would like the feedback to include this information.
Comment 1 Katrin Fischer 2019-02-10 20:38:17 UTC
Created attachment 84950 [details] [review]
Bug 17236: Add minute an dhours to last checked out item on circulation for hourly loans

This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]

The time part of the due date will only display if it's an hourly loan (!=23:59)

To test:
- Check out 2 items
  - One with a loan period in days
  - One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan
Comment 2 Owen Leonard 2019-02-15 15:22:19 UTC
Created attachment 85181 [details] [review]
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans

This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]

The time part of the due date will only display if it's an hourly loan (!=23:59)

To test:
- Check out 2 items
  - One with a loan period in days
  - One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Mikaël Olangcay Brisebois 2019-02-15 20:12:50 UTC
Created attachment 85191 [details] [review]
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans

This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]

The time part of the due date will only display if it's an hourly loan (!=23:59)

To test:
- Check out 2 items
  - One with a loan period in days
  - One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
Comment 4 Josef Moravec 2019-02-20 12:22:34 UTC
Created attachment 85330 [details] [review]
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans

This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]

The time part of the due date will only display if it's an hourly loan (!=23:59)

To test:
- Check out 2 items
  - One with a loan period in days
  - One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Nick Clemens 2019-02-22 15:04:39 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-02-26 09:33:49 UTC
Pushed to 18.11.x for 18.11.04
Comment 7 Lucas Gass 2019-03-08 02:19:55 UTC
backported to 18.05.x for 18.05.11