It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out.
Created attachment 33764 [details] [review] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due"
Created attachment 33765 [details] [review] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due"
I think this is an important step towards making the AJAX circ feature more usable, but I think it would be good to get some opinions from librarians about this implementation.
Here's the way it works with Kyle's patch: http://www.screencast.com/t/qNw2U3hwz I'm inclined to do something less obtrusive: http://www.screencast.com/t/1gsa2prF ...on the assumption that the visual aspect of checking out was working fine before AJAX circ, and fixes to AJAX circ should look to returning things to a proven-functional state. However, always assuming that it was better before would prevent us from making improvements, so I want hear opinions.
(In reply to Owen Leonard from comment #4) > Here's the way it works with Kyle's patch: > > http://www.screencast.com/t/qNw2U3hwz > > I'm inclined to do something less obtrusive: > > http://www.screencast.com/t/1gsa2prF > > ...on the assumption that the visual aspect of checking out was working fine > before AJAX circ, and fixes to AJAX circ should look to returning things to > a proven-functional state. > > However, always assuming that it was better before would prevent us from > making improvements, so I want hear opinions. Owen, I would be more inclined to see the feedback in the same area that I'm scanning in (in the same box). Maybe at the bottom? It is less scanning around the screen. You are already looking there when scanning, why not have it in the same area? The concept is similar to switching between the keyboard and mouse. If I am given the option, I will choose a technique that requires the least amount of reorientation. Just my two cents. Christopher
(In reply to Christopher Brannon from comment #5) > I would be more inclined to see the feedback in the same area that I'm > scanning in (in the same box). Maybe at the bottom? I like this idea too! Here's my take: http://www.screencast.com/t/ZcsPfJabP The advantage to this method is that the feedback is visible even for patrons with lost of information in the messages column: http://www.screencast.com/t/3uEHAaWnUyc
If I have a vote it's for this one. http://www.screencast.com/t/ZcsPfJabP
(In reply to Owen Leonard from comment #6) > (In reply to Christopher Brannon from comment #5) > > I would be more inclined to see the feedback in the same area that I'm > > scanning in (in the same box). Maybe at the bottom? > > I like this idea too! Here's my take: > > http://www.screencast.com/t/ZcsPfJabP > > The advantage to this method is that the feedback is visible even for > patrons with lost of information in the messages column: > > http://www.screencast.com/t/3uEHAaWnUyc Excellent. My OCD side of me says indent everything past "Checked out:" so it is more visually attractive. Something like this: http://screencast.com/t/EC4qcKNixO But this is just a simulated example. Don't know how the formatting would actually look or work. I'd also suggest a contrasting background color to help bring attention to it. Unlike some of the warning messages that are yellow, I'd maybe use a faint green background? Here's another example, with the header above and slightly larger, with a colored background: http://screencast.com/t/hDNBknJ8e Anyway, I think placement is excellent. Christopher
Created attachment 34250 [details] [review] [SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display.
Created attachment 34251 [details] [review] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed.
Looks good.
Created attachment 34253 [details] [review] [SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us>
Created attachment 34254 [details] [review] [SIGNED-OFF] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I just wanted to add that Owen's followup looks fantastic! Great work!
Created attachment 34384 [details] [review] [PASSED QA] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 34385 [details] [review] [PASSED QA] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Everything looks good, but it doesn't apply anymore, please rebase!
Created attachment 36290 [details] [review] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36291 [details] [review] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36292 [details] [review] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 37776 [details] [review] Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t C4::Circulation::AddIssue now returns a Koha::Schema::Result::Issue object so tests need to be fixed. The old behaviour was to always return the due date. It now returns undef if no issue performed. So one of the tests become irrelevant. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patches pushed to master. Thanks Kyle and Owen, nice job!
String changes held for 3.18.7
Applied on 3.18.x will be in 3.18.7
Change in return causes sipserver instances to crash on renewals : see bug 14673 for description and workaround
I love this patch a lot, but am I the only one who seems to get nothing in the [% issue.item.biblio.title %]? I only get the barcode and due date (both production server and my dev-install). Since I seem to remember this one working fine I'd just like to hear from others before I do any really extensive testing on my setup.
(In reply to Viktor Sarge from comment #26) > I love this patch a lot, but am I the only one who seems to get nothing in > the [% issue.item.biblio.title %]? I only get the barcode and due date > (both production server and my dev-install). Since I seem to remember this > one working fine I'd just like to hear from others before I do any really > extensive testing on my setup. I Viktor - I just checked, the title, barcode and due date display nicely in my tests.
(In reply to Katrin Fischer from comment #27) > (In reply to Viktor Sarge from comment #26) > > I love this patch a lot, but am I the only one who seems to get nothing in > > the [% issue.item.biblio.title %]? I only get the barcode and due date > > (both production server and my dev-install). Since I seem to remember this > > one working fine I'd just like to hear from others before I do any really > > extensive testing on my setup. > > I Viktor - I just checked, the title, barcode and due date display nicely in > my tests. Thanks for the feedback Katrin! It was gone for a while, but it was patched with some later release and I had already forgotten about commenting on this thread by then. Sorry for the extra work!