Bug 17277

I cannot reproduce this problem in version 16.05 or in the master branch. It seems likely that this is a data or configuration issue. I suggest bringing it to the Koha mailing list to see if anyone there has suggestions.

The error occurs, if you have just one library defined in system administration. To reproduce:

1. Make sure you have one library defined.
2. Catalog any title and attach an item
3. Check current location in your OPAC - nothing is shown
4. Add a second library in system administration
5. Check current location again - now it's displayed

See images attached.

Created attachment 57410 [details]
Koha current location

Hm, I am not sure if this was an intended effect caused by the removal of the SingleBranch system preference. Does it still show locations (LOC)?

(In reply to Katrin Fischer from comment #4)
> Hm, I am not sure if this was an intended effect caused by the removal of
> the SingleBranch system preference. Does it still show locations (LOC)?

Yes, locations are still displayed.

(In reply to Katrin Fischer from comment #4)
> Hm, I am not sure if this was an intended effect caused by the removal of
> the SingleBranch system preference.

No I don't think it comes from bug 4941.

I've seen this too now, on 16.11.08

Adding a dummy branch fixes it.

Hi Liz, so it appears when there is no branch set at all?

Ok, recreated.

What happens:
If there is only 1 library defined we only display items.location. If it is not mapped, it is empty.
If there is more than 1 library defined, we display items.*branch (depending on OpacLocationBranchToDisplay) AND items.location.

I have no idea what the fix could be.

I think this was intentional - it's the behaviour as it was with SingleBranchLibrary, that was removed in favour of checking for the number of branches in a library.

I'm reminded of this: 

https://xkcd.com/1172/

So basically, we should tell single branch libraries to add a location to all of their items, otherwise that column looks weirdly empty.

Or we should check to see if any items have locations, and not display the column if no items have it.

What do you think?

Maybe intentional, but not well thought through. - The second one is better, of course. Would we also want to change the column name in those cases? Not sure what it reads now.

What about removing the UNLESS singleBranchMode condition? It will display both the location and the *branch in any cases.

Created attachment 65008 [details] [review]
Bug 17277: Always display location and *branch item info - opac detail

I just don't know - not showing the branch for a single branch is I think, a good change.

For libraries that don't also have locations in (all of) their records, it can be quite awkward looking in the OPAC.

Really not sure how best to go about appeasing all of the different ways libraries want to show this data. I'd say "add a preference" except that's annoying - we have so many already. I'd say "use CSS or jquery to hide it" but that's inaccessible or much harder for lots of library staff who are in charge of a Koha.

Putting it all back the way it was before is appealing, but also meh because it'll break someone's wishes somewhere.

Maybe it's best to make an actual preference for "single branch mode" to specify that single branch mode is an actual settable "mode" and not something we've intuited based on the number of branches. 

So hard! Arg!

Another finding:

As described, if there is only one single library branch in the OPAC the holdings detail table doesn't show anything in the "current location" field of any single hit.

But if you click the "MARC" tab of that same single hit the holdings detail table at the end of the MARC listing DOES show the "current location".

I don't see any reason why to display an empty field instead of the "current location" at one place but displaying (or creating) its content at another place. If the system can't display its content the field shouldn't be there at all.

However - as suggested by Liz Rea - easiest way to fix the problem is adding a second (dummy) library branch.

What shows in the MARC view or not is configured in the MARC bibliographic frameworks to the preference of the library.

Created attachment 65499 [details] [review]
[SIGNED-OFF] Bug 17277: Always display location and *branch item info - opac detail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Considering Bug 16759 I think this patch is the right solution.

Created attachment 65514 [details] [review]
Bug 17277: Always display location and *branch item info - opac detail

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Liz, Katrin, do you agree with this patch?

I thought that when there is only one library, showing the library on each item was not necessary. We even had libraries asking to remove the branch information from the staff side as well, because they felt it was taking up space unnecessarily. But from the comments it appears that not every library shares this view.

Even with bug 16759 I think we won't quite get the current or ideal behaviour (only show the column, if there is a location (LOC) for the item defined).

But it might be a step forward to find other ways of resolving this.

I'm really not sure. The column hiding thing only works if you want ALL of it gone. What if you still want to see the location but not the branch?

Liz is correct about this, the current behaviour won't be brought back by bug 16759.

(In reply to Liz Rea from comment #23)
> What if you still want to see the location but not the branch?

Bug 19028?

So a plan would be to push bug 19028, bug 16759 and this one altogether?

Comment on attachment 57410 [details]
Koha current location

I think that's alright, yes.

Pushed to master for 17.11, thanks to everybody involved!