| Summary: | waitingreserves.pl should keep you on the same tab when cancelling a hold | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
| Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lisettepalouse+koha, nick, r.delahunty |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Hi Christopher, waitingreserves.pl should now keep you on the same tab once bug 23192 is addressed. Can you explain the focus? I am not sure what you mean. Should the page default to focus in the search/filter box for the table of reserves? -Nick This is an old request. If there were an option to do that, it would be great. I don't think it should just focus on that search filter always, but if there were a check box to keep the focus, that would streamline the use of this page for those that are going through a pile of holds that need to be cancelled. (In reply to Christopher Brannon from comment #2) > This is an old request. If there were an option to do that, it would be > great. I don't think it should just focus on that search filter always, but > if there were a check box to keep the focus, that would streamline the use > of this page for those that are going through a pile of holds that need to > be cancelled. I am afraid I don't understand - can you describe the workflow where focus is lost? Do you mean if you search, then click a cancel link, the focus should return to the search? i.e. if the search box is populated we should focus there on page load? When Christopher talks about the "loss of focus" does he mean that the loss of both the sort order and the limitation to a specific library? We have 6 libraries and the workflow staff are accustomed to was to limit to their branch, sort by user name order, and then go along the hold shelf removing the items and cancelling the hold and returning the item to the shelf (or setting the item aside for return to library it belongs to, or triggering the next hold). Now the loss of focus includes the need to move back to the RHS tab, limit to library again, and sort again. BTW the bug 23192 has already lead to data damage where staff have accidently cancelled an unfulfilled hold (one on the tab they were forced back to!). Our support company were unsuccessful in back porting the fix for 23192 into our 18.11 Koha version. (In reply to Nick Clemens from comment #3) > (In reply to Christopher Brannon from comment #2) > > This is an old request. If there were an option to do that, it would be > > great. I don't think it should just focus on that search filter always, but > > if there were a check box to keep the focus, that would streamline the use > > of this page for those that are going through a pile of holds that need to > > be cancelled. > > I am afraid I don't understand - can you describe the workflow where focus > is lost? Do you mean if you search, then click a cancel link, the focus > should return to the search? i.e. if the search box is populated we should > focus there on page load? Yes. That is correct. If you look at the jquery, it does exactly what I am explaining. (In reply to Christopher Brannon from comment #5) > (In reply to Nick Clemens from comment #3) > > (In reply to Christopher Brannon from comment #2) > > > This is an old request. If there were an option to do that, it would be > > > great. I don't think it should just focus on that search filter always, but > > > if there were a check box to keep the focus, that would streamline the use > > > of this page for those that are going through a pile of holds that need to > > > be cancelled. > > > > I am afraid I don't understand - can you describe the workflow where focus > > is lost? Do you mean if you search, then click a cancel link, the focus > > should return to the search? i.e. if the search box is populated we should > > focus there on page load? > > Yes. That is correct. If you look at the jquery, it does exactly what I am > explaining. (In reply to Ray Delahunty from comment #4) > When Christopher talks about the "loss of focus" does he mean that the loss > of both the sort order and the limitation to a specific library? We have 6 > libraries and the workflow staff are accustomed to was to limit to their > branch, sort by user name order, and then go along the hold shelf removing > the items and cancelling the hold and returning the item to the shelf (or > setting the item aside for return to library it belongs to, or triggering > the next hold). Now the loss of focus includes the need to move back to the > RHS tab, limit to library again, and sort again. BTW the bug 23192 has > already lead to data damage where staff have accidently cancelled an > unfulfilled hold (one on the tab they were forced back to!). Our support > company were unsuccessful in back porting the fix for 23192 into our 18.11 > Koha version. Loss of focus means the cursor is not staying on the search box at the top of the list. Nothing to do with sort. I see how that it could be beneficial to keep the sort though. On any page for that matter. Still valid or valid again. |
When you cancel a hold on the Hold(s) over tab, and the process is done, it puts you back on the Hold(s) waiting tab. It should keep you on the same tab. It would also be nice if the search box is used that it would keep the focus. We use the following jQuery to help streamline the cancelling process: //Default Holds awaiting pickup to Holds over tab $("#holdso form[action='waitingreserves.pl']").attr("action","waitingreserves.pl#holdsover"); if (window.location.href.indexOf("cgi-bin/koha/circ/waitingreserves.pl#holdsover") > -1) { $("form[action='waitingreserves.pl']").attr("action","waitingreserves.pl#holdsover"); } setTimeout(function() { $("#holdso_filter input").focus(); },10); //End default tab