|
Description
Josef Moravec
2016-12-07 10:07:47 UTC
Created attachment 58009 [details] [review] Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Created attachment 58010 [details] [review] Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence Paid a fine using the pay button in right column. Reversed the payment using the reverse button dropdown Now, action displays "Pay" and dropdown arrow appears but know options visible. Should the dropdown arrow be removed since there are no longer are options? Or should the "write off" and "print" be displayed in the dropdown menu again? (In reply to Chris Kirby from comment #3) > Paid a fine using the pay button in right column. > Reversed the payment using the reverse button dropdown > Now, action displays "Pay" and dropdown arrow appears but know options > visible. > Should the dropdown arrow be removed since there are no longer are options? > Or should the "write off" and "print" be displayed in the dropdown menu > again? You are right, there should always be the print action. I'll attach a followup soon. Created attachment 58115 [details] [review] Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). Radek, what did you do with the patches? Looks like you join the second patch with commit message of first patch, so there is now code for second patch twice and no code from first patch... If don't know what happens, I can resubmit the original patches... I was contacted by Radek off Bugzilla and he now knows where the problem is and will try to re-sign off it, so I obsolete his attachment and unobsolete the original one. Created attachment 58169 [details] [review] Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some paid and some unpaid 1) Apply the patch 2) git grep reverse_col should not return any appearence 3) Go to boraccount page, the last column header should have "Actions" title 4) In the rightmost column you should see apropriate combination of buttons for each row: Print - fee which was written-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permission to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 5) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> Created attachment 58171 [details] [review] Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> Please forgive me, I'm really trying to do my best :-( I'm about to sign-off again. Created attachment 58174 [details] [review] Bug 17734: Make possible to pay and writeoff from boraccount page and make action buttons split button Test plan 0) Have a patron with some fines - some payd and some unpaid 1) Apply the patch 2) Go to boraccount.pl page 3) In most right column you should see apropriate combination of buttons for each row: Print - fee which was writted-off and write-off line Pay + Print in dropdown - unpaid fee, for user without permissin to writeoff Pay + Print and Write off in dropdown - unpaid fee, user with permission to writeoff Print + Reverse in dropdown - for payment row 4) Try all combination and use buttons and confirm they work as expected Signed-off-by: Radek Šiman <rbit@rbit.cz> Created attachment 58175 [details] [review] Bug 17734: Get rid of reverse_col parameter As it's not needed anymore, we have at least "Print" action button for each row Test plan: 1) Go to boraccount page, the last column header should have "Actions" title 2) git grep reverse_col should not return any appearence Signed-off-by: Radek Šiman <rbit@rbit.cz> I get a menu with "Pay", an arrow to open the dropdown, but it is empty. To recreate: - Create a manual invoice - Account tab, click pay - Reverse the payment *** This bug has been marked as a duplicate of bug 24604 *** *** This bug has been marked as a duplicate of bug 24079 *** |