Description
Jonathan Druart
2016-12-20 13:00:59 UTC
Created attachment 58290 [details] [review] Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass Created attachment 58291 [details] [review] Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Created attachment 58292 [details] [review] Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Created attachment 58296 [details] [review] Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 58297 [details] [review] Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 58301 [details] [review] Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] Koha::Issues and Koha::Checkouts have been added to the codebase to represent the same thing. In ODLIS the word Issue is never used in the sense we use it. Another problem with Issue is it has so many meaning in English (such as problem/bug) The word Checkout *is* in ODLIS, closer to what we use: http://www.abc-clio.com/ODLIS/odlis_c.aspx#checkoutslip Test plan: git grep Koha::Issue should not return any occurrences and the tests must still pass Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 58302 [details] [review] Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.05, thanks Jonathan! This won't get ported back to 16.11.x as it is an enhancement. How might this be related to 16870? *** Bug 16870 has been marked as a duplicate of this bug. *** |