Bug 16870 - Koha::Issue(s) should be named Koha::Checkout(s)
Summary: Koha::Issue(s) should be named Koha::Checkout(s)
Status: RESOLVED DUPLICATE of bug 17796
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on: 6906 16086
Blocks:
  Show dependency tree / graph
 
Reported: 2016-07-07 14:26 UTC by Kyle M Hall (khall)
Modified: 2017-01-17 07:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16870 - Move and rename class files and unit tests (3.45 KB, patch)
2016-07-07 16:14 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 16870 - Update Koha::Patron use of the class (1.59 KB, patch)
2016-07-07 16:16 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 16870 - Move and rename class files and unit tests (9.05 KB, patch)
2016-07-13 13:51 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 16870 - Update Koha::Patron use of the class (1.59 KB, patch)
2016-07-13 13:51 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 16870 - Move and rename class files and unit tests (7.46 KB, patch)
2016-07-13 13:55 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 16870 - Update Koha::Patron use of the class (1.59 KB, patch)
2016-07-13 13:55 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16870 - Move and rename class files and unit tests (7.51 KB, patch)
2016-07-15 02:20 UTC, Srdjan Jankovic 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16870 - Update Koha::Patron use of the class (1.64 KB, patch)
2016-07-15 02:22 UTC, Srdjan Jankovic 		Details | Diff | Splinter Review
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2016-07-07 14:26:05 UTC 
By our naming guidelines, the term "issue" is deprecated in favor of "checkout". We should update the class names to match.
Comment 1 Kyle M Hall (khall) 2016-07-07 16:14:59 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2016-07-07 16:16:28 UTC Comment hidden (obsolete)
Comment 3 Srdjan Jankovic 2016-07-13 06:00:57 UTC 
Kyle, Koha::Checkout(s) was added in 14757, patch 1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52924
Comment 4 Kyle M Hall (khall) 2016-07-13 13:06:58 UTC 
(In reply to Srdjan Jankovic from comment #3)
> Kyle, Koha::Checkout(s) was added in 14757, patch 1
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52924

Yes, I noticed that! I will need to modify this patch set to take that into account.
Comment 5 Kyle M Hall (khall) 2016-07-13 13:51:16 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall (khall) 2016-07-13 13:51:23 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall (khall) 2016-07-13 13:55:12 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall (khall) 2016-07-13 13:55:18 UTC Comment hidden (obsolete)
Comment 9 Srdjan Jankovic 2016-07-15 02:20:52 UTC 
Created attachment 53407 [details] [review]
[SIGNED-OFF] Bug 16870 - Move and rename class files and unit tests

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Comment 10 Srdjan Jankovic 2016-07-15 02:22:24 UTC 
Created attachment 53408 [details] [review]
[SIGNED-OFF] Bug 16870 - Update Koha::Patron use of the class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t
3) prove t/db_dependent/Koha/Checkouts.t

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Comment 11 Jonathan Druart 2016-07-15 12:52:48 UTC 
Should not we rename OldIssue[s] as well?
Comment 12 Jonathan Druart 2017-01-17 07:47:49 UTC 

*** This bug has been marked as a duplicate of bug 17796 ***