Description
Jonathan Druart
2017-03-13 19:39:22 UTC
Created attachment 61053 [details] [review] Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Patch was unable to apply: Applying: Bug 18260: Koha::Biblio - Remove GetBiblio Using index info to reconstruct a base tree... M C4/Acquisition.pm M C4/Biblio.pm M C4/ILSDI/Services.pm M C4/ImportBatch.pm M C4/Serials.pm M Koha/REST/V1/Hold.pm M catalogue/imageviewer.pl M catalogue/itemsearch.pl M t/db_dependent/Acquisition.t M tools/batch_delete_records.pl Falling back to patching base and 3-way merge... Auto-merging tools/batch_delete_records.pl CONFLICT (content): Merge conflict in tools/batch_delete_records.pl Auto-merging t/db_dependent/Acquisition.t Auto-merging catalogue/itemsearch.pl Auto-merging catalogue/imageviewer.pl Auto-merging Koha/REST/V1/Hold.pm Auto-merging C4/Serials.pm Auto-merging C4/ImportBatch.pm Auto-merging C4/ILSDI/Services.pm Auto-merging C4/Biblio.pm Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 18260: Koha::Biblio - Remove GetBiblio Created attachment 63743 [details] [review] Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Created attachment 63760 [details] [review] Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Koha/REST/V1/Hold.pm Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of GetBiblio was not tested too before. No blocker. catalogue/imageviewer.pl biblionumber is a CGI parameter here find should be tested Same for catalogue/issuehistory.pl opac/opac-imageviewer.pl Created attachment 64823 [details] [review] Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 64825 [details] [review] Bug 18260: Handle nonexistent biblionumber in imageviewer.pl (In reply to Marcel de Rooy from comment #5) > Koha/REST/V1/Hold.pm > Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of > GetBiblio was not tested too before. > No blocker. > > catalogue/imageviewer.pl > biblionumber is a CGI parameter here > find should be tested That was already true before this patch, we must handle nonexistent biblionumber correctly on all catalogue scripts. > Same for catalogue/issuehistory.pl > opac/opac-imageviewer.pl I did not find a change in the behaviour. Created attachment 64897 [details] [review] Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 64898 [details] [review] Bug 18260: Handle nonexistent biblionumber in imageviewer.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 64899 [details] [review] Bug 18260: [QA Follow-up] Always something left? Remove second Koha::Biblios->find in imageviewer.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |