Summary: | Set memcached as 'enabled' by default | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | abl, fridolin.somers, jonathan.druart, josef.moravec, julian.maurice, katrin.fischer, kyle, m.de.rooy, martin.renvoize, tomascohen |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Memcached is now required and enabled by default.
|
Version(s) released in: | |
Bug Depends on: | |||
Bug Blocks: | 18250, 20801, 21426 | ||
Attachments: |
Bug 18342: Enable memcached by default for new installs
Bug 18342: Enable memcached by default for new installs Bug 18342: Mark Cache::Memcached as mandatory Bug 18342: Enable memcached by default for new installs Bug 18342: Mark Cache::Memcached as mandatory Bug 18342: Enable memcached by default for new installs Bug 18342: Mark Cache::Memcached as mandatory |
Description
Mason James
2017-03-28 07:03:07 UTC
And remove the other cache types: Cache::Memory etc. (In reply to Marcel de Rooy from comment #1) > And remove the other cache types: Cache::Memory etc. Not Cache::Memory, it should be kept as a fallback way in case memcached is not reachable. (In reply to Jonathan Druart from comment #2) > (In reply to Marcel de Rooy from comment #1) > > And remove the other cache types: Cache::Memory etc. IMO at least fastmmap definitely should be removed, it's long overdue. > > Not Cache::Memory, it should be kept as a fallback way in case memcached is > not reachable Cache::Memory does't work all that well as a fallback mechanism.. Under normal circumstances it's just slowing things out (values are stored there, but never retrieved back). And under more unusual circumstances (e.g. if we want to flush L1 cache in daemon scripts periodically) it's pretty much the same - while Cache::Memory supports expiration, currently we don't use it (properly), and the final result is once again 100% waste of CPU cycles, without any gains at all. I wonder if a better fallback for memcached L2 cache could rather be: no L2 cache, or maybe some kind of dummy L2 cache. It does mater only in case of daemon scripts - if it's not a daemon script etc., Cache::Memory will always be a waste of time anyway. Created attachment 67414 [details] [review] Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default Can this be tested on kohadevbox? (In reply to Katrin Fischer from comment #5) > Can this be tested on kohadevbox? You can test koha-create, yes. Shouldn't be Cache::Memcached module marked as required in PerlDependencies then? Created attachment 73216 [details] [review] Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default Created attachment 73217 [details] [review] Bug 18342: Mark Cache::Memcached as mandatory This looks good to me, but not enough time to test it anymore Created attachment 74607 [details] [review] Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 74608 [details] [review] Bug 18342: Mark Cache::Memcached as mandatory Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Shouldn't memcached be moved from Suggests to Depends in debian/control ? (In reply to Julian Maurice from comment #13) > Shouldn't memcached be moved from Suggests to Depends in debian/control ? That's generated QA: Looking here Just noting that running koha-create without --create-db (which probably is only theoretical) tells me: failed to load external entity "/etc/koha/sites/test02/koha-conf.xml" What about removing Cache::FastMmap ? Created attachment 74904 [details] [review] Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 74905 [details] [review] Bug 18342: Mark Cache::Memcached as mandatory Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #16) > Just noting that running koha-create without --create-db (which probably is > only theoretical) tells me: failed to load external entity > "/etc/koha/sites/test02/koha-conf.xml" See bug 18983 (In reply to Marcel de Rooy from comment #17) > What about removing Cache::FastMmap ? See bug 16067 Thanks for QAing this one! Pushed to master for 18.05, thanks to everybody involved! I prefer not to push on stable branch 17.11.x, its not a real bug. |