Summary: | Transfer message confusing, cancel button missing | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Circulation | Assignee: | Christopher Brannon <cbrannon> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | alexbuckley, anoorazerin, gmcharlt, koha, kyle.m.hall, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21346 | ||
Bug Blocks: | 18503 | ||
Attachments: |
[Bug 18490] Change transfer message/show cancel
Applied the patch but no changes No Cancel button displayed |
Description
Christopher Brannon
2017-04-24 23:50:35 UTC
Created attachment 62649 [details] [review] [Bug 18490] Change transfer message/show cancel This patch changes the transfer message and shows the cancel button on the first checkin. I've also cleaned up some formatting in the code. To test: Test A: 1) Check in an item at a library other than its homebranch. Test B: 2) Place an item on hold to be picked up at another library. 3) Check in the item at a library other than the home branch or pickup loccation. Test C: 4) Add item to a rotating collection. 5) Transfer collection to another library. 6) Check in the item to trigger the transfer. 7) On each test, notice the phrase "Please transfer item to:" and notice that the Cancel transfer button does not appear on the first checkin. 8) Apply patch. 9) Repeat steps 1-6. 10) On each test notice the phrase is now "Transferring item to:" and notice that the Cancel transfer button now shows after the first checkin. Created attachment 64561 [details]
Applied the patch but no changes
We have tested the patch, doing all the Test Plan and repeat the Test Plan after applying the patch.
We find out that there are no changes after patch is applied. We tested in Sandbox01, BibLibre UNIMARC on 23rd June 2017, 1000am Philippine Time. Attachment shows the dialog box after the patch is applied, there are no 'Cancel' button. So does on the other Test Plan.
Patch works. Maybe sandbox testing issue. Test environment may need a restart? Created attachment 66967 [details]
No Cancel button displayed
Hi Christopher
When I tested this patch I found that the 'Transferring item to:' text was displayed in Test A, B, and C however the 'Cancel' button is only being displayed in test C
OK so I have now got it displaying the 'cancel transfer' button, so the patch works as described in the test plan. However running the QA test it fails on valid_template, could you please fix this up Christopher and then I'll be happy to re-test and sign off on your patch FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template I'm going to hold off on this until 21346 is pushed. Doesn't completely depend on it, but there are enough changes there that I would like to work from that point forward. |