Bug 18493

Summary: Add more languages to advanced search languages dropdown
Product: Koha Reporter: Lari Taskula <lari.taskula>
Component: I18N/L10NAssignee: Lari Taskula <lari.taskula>
Status: Failed QA --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: f.demians, fridolin.somers, januszop, jonathan.druart, m.de.rooy, severine.queune, tomascohen, veron
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15067, 29596, 29605    
Bug Blocks:    
Attachments: Bug 18493: Add new searchable languages
Bug 18493: Add new searchable languages
Bug 18493: Add new searchable languages
Bug 18493: Add new searchable languages

Description Lari Taskula 2017-04-25 13:09:26 UTC
Our librarians have requested some languages to be added into the advanced search language dropdown list. Will list them in a comment after attaching patches.
Comment 1 Lari Taskula 2017-04-25 13:30:45 UTC
Created attachment 62678 [details] [review]
Bug 18493: Add new searchable languages

This patch adds the following languages into advanced search "Languages" dropdown:

Bosnian
Welsh
Esperanto
Estonian
Irish Gaelic
Scottish Gaelic
ncient Greek
Kazakh
Greenlandic
Karelian
Cornish
Lithuanian
Latvian
Burmese
Punjabi
Pashto
Finnish Kalo
Sanskrit
Akkala Sami
Kildin Sami
Ter Sami
Pite Sami
Kemi Sami
Ume Sami
Southern Sami
Northern Sami
Sami languages
Lule Sami
Inari Sami
Skolt Sami
Somali
Sotho
Votic
Yiddish

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Go to intranet advanced search
3. Click "More options"
4. See "Limits" fieldset, it should have "Language" drop down
5. Observe that the languages provided in this patch are visible in this dropdown
Comment 2 Lari Taskula 2017-04-25 13:31:46 UTC
Created attachment 62679 [details] [review]
Bug 18493: Add new searchable languages

This patch adds the following languages into advanced search "Languages" dropdown:

Bosnian
Welsh
Esperanto
Estonian
Irish Gaelic
Scottish Gaelic
Ancient Greek
Kazakh
Greenlandic
Karelian
Cornish
Lithuanian
Latvian
Burmese
Punjabi
Pashto
Finnish Kalo
Sanskrit
Akkala Sami
Kildin Sami
Ter Sami
Pite Sami
Kemi Sami
Ume Sami
Southern Sami
Northern Sami
Sami languages
Lule Sami
Inari Sami
Skolt Sami
Somali
Sotho
Votic
Yiddish

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Go to intranet advanced search
3. Click "More options"
4. See "Limits" fieldset, it should have "Language" drop down
5. Observe that the languages provided in this patch are visible in this dropdown
Comment 3 Marc Véron 2017-05-09 04:32:10 UTC
Created attachment 63265 [details] [review]
Bug 18493: Add new searchable languages

This patch adds the following languages into advanced search "Languages" dropdown:

Bosnian
Welsh
Esperanto
Estonian
Irish Gaelic
Scottish Gaelic
Ancient Greek
Kazakh
Greenlandic
Karelian
Cornish
Lithuanian
Latvian
Burmese
Punjabi
Pashto
Finnish Kalo
Sanskrit
Akkala Sami
Kildin Sami
Ter Sami
Pite Sami
Kemi Sami
Ume Sami
Southern Sami
Northern Sami
Sami languages
Lule Sami
Inari Sami
Skolt Sami
Somali
Sotho
Votic
Yiddish

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Go to intranet advanced search
3. Click "More options"
4. See "Limits" fieldset, it should have "Language" drop down
5. Observe that the languages provided in this patch are visible in this dropdown

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Marcel de Rooy 2017-09-01 06:59:36 UTC
Created attachment 66688 [details] [review]
Bug 18493: Add new searchable languages

This patch adds the following languages into advanced search "Languages" dropdown:

Bosnian
Welsh
Esperanto
Estonian
Irish Gaelic
Scottish Gaelic
Ancient Greek
Kazakh
Greenlandic
Karelian
Cornish
Lithuanian
Latvian
Burmese
Punjabi
Pashto
Finnish Kalo
Sanskrit
Akkala Sami
Kildin Sami
Ter Sami
Pite Sami
Kemi Sami
Ume Sami
Southern Sami
Northern Sami
Sami languages
Lule Sami
Inari Sami
Skolt Sami
Somali
Sotho
Votic
Yiddish

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Go to intranet advanced search
3. Click "More options"
4. See "Limits" fieldset, it should have "Language" drop down
5. Observe that the languages provided in this patch are visible in this dropdown

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Just noting that the order in this dropdown is hopeless.
Comment 5 Jonathan Druart 2017-09-01 14:29:24 UTC
You need to check the existence of these languages in the update DB, otherwise they will be duplicated.

Note: the "added" column is wrong, but useless as well. It should be an automatic timestamp.
Comment 6 Fridolin Somers 2021-04-02 13:03:05 UTC
This would be useful.
Comment 7 Séverine Queune 2022-04-19 08:12:34 UTC
(In reply to Fridolin Somers from comment #6)
> This would be useful.
I completely agree !

Maybe a silly proposition (or technically impossible to apply...) but why don't use the authorized values list dedicated to languages for this list ?

That way, each library would have available in this list only the languages ​​actually present in its catalog.
It would also be easier to find the language we want, because the order of this list is a little bit esoteric in my view :/
Comment 8 Katrin Fischer 2022-04-21 19:11:02 UTC
I think sorting/display could be improved by using the "translated name" of the language for sorting.

A reason why we don't use authorised values is translatability, especially if you offer the OPAC in multiple languages. I know that Bernardo once tried to move them out of the database and make them translatable in Pootle: bug 12017
Comment 9 Séverine Queune 2022-04-22 07:50:47 UTC
(In reply to Katrin Fischer from comment #8)
> A reason why we don't use authorised values is translatability, especially
> if you offer the OPAC in multiple languages.

Oh ! You're totally right, I completely missed this point !
Comment 10 Janusz Kaczmarek 2024-04-12 21:04:46 UTC
This bug is very similar to the bug 33134 which has been quasi approved today (not yet QA).

After the application of the patch from 33134 (and earlier additions), 22 languages from this patch will be still missing (and possibly also some more descriptions of the languages):

rfc4646 iso639
kl   kal
krl   krl
kw   cor
my   bur
pa   pan
ps   pus
rmf   rmf
sia   sia
sjd   sjd
sjt   sjt
sje   sje
sjk   sjk
sju   sju
sma   sma
sme   sme
smi   smi
smj   smj
smn   smn
sms   sms
so   som
st   sot
vot   vot

Maybe the author of this patch would like to consider correcting and resubmitting it in the form similar to that of the bug 33134 -- it should be OK now...