| Summary: | Many languages are missing from the advanced search languages dropdown | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
| Component: | I18N/L10N | Assignee: | Lari Taskula <lari.taskula> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, januszop, jonathan.druart, lucas, m.de.rooy, severine.queune, tomascohen, veron |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 15067, 29596, 29605, 33134, 34328 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18493: Add new searchable languages
Bug 18493: Add new searchable languages Bug 18493: Add new searchable languages Bug 18493: Add new searchable languages Bug 18493: Add new searchable languages Bug 18493: Modernise DB update Bug 18493: (follow-up) Fix typo descriptionsn |
||
|
Description
Lari Taskula
2017-04-25 13:09:26 UTC
Created attachment 62678 [details] [review] Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic ncient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Created attachment 62679 [details] [review] Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic Ancient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Created attachment 63265 [details] [review] Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic Ancient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 66688 [details] [review] Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic Ancient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Just noting that the order in this dropdown is hopeless. You need to check the existence of these languages in the update DB, otherwise they will be duplicated. Note: the "added" column is wrong, but useless as well. It should be an automatic timestamp. This would be useful. (In reply to Fridolin Somers from comment #6) > This would be useful. I completely agree ! Maybe a silly proposition (or technically impossible to apply...) but why don't use the authorized values list dedicated to languages for this list ? That way, each library would have available in this list only the languages actually present in its catalog. It would also be easier to find the language we want, because the order of this list is a little bit esoteric in my view :/ I think sorting/display could be improved by using the "translated name" of the language for sorting. A reason why we don't use authorised values is translatability, especially if you offer the OPAC in multiple languages. I know that Bernardo once tried to move them out of the database and make them translatable in Pootle: bug 12017 (In reply to Katrin Fischer from comment #8) > A reason why we don't use authorised values is translatability, especially > if you offer the OPAC in multiple languages. Oh ! You're totally right, I completely missed this point ! This bug is very similar to the bug 33134 which has been quasi approved today (not yet QA). After the application of the patch from 33134 (and earlier additions), 22 languages from this patch will be still missing (and possibly also some more descriptions of the languages): rfc4646 iso639 kl kal krl krl kw cor my bur pa pan ps pus rmf rmf sia sia sjd sjd sjt sjt sje sje sjk sjk sju sju sma sma sme sme smi smi smj smj smn smn sms sms so som st sot vot vot Maybe the author of this patch would like to consider correcting and resubmitting it in the form similar to that of the bug 33134 -- it should be OK now... Created attachment 167122 [details] [review] Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Greenlandic Karelian Cornish Burmese Punjabi Pashto Finnish Kalo Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Just noting that the order in this dropdown is hopeless. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 167123 [details] [review] Bug 18493: Modernise DB update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sorted out the QA comments and updated to current best practices. I think this is ready to go without delay now. I have pondered this one, but I don't want to do another database update right now. It will be top of list once the release is out. Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Created attachment 167626 [details] [review] Bug 18493: (follow-up) Fix typo descriptionsn Doh, thanks Nick.. follow-up pushed. |