Created attachment 128094 [details] [review] Bug 29596: Add Yiddish language This patch adds the Yiddish language to Koha. The language codes were taken from https://www.loc.gov/standards/iso639-2/php/code_list.php Sponsored-by: Universidad Nacional de San Martín Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 128097 [details] [review] Bug 29596: Add Yiddish language This patch adds the Yiddish language to Koha. The language codes were taken from https://www.loc.gov/standards/iso639-2/php/code_list.php Sponsored-by: Universidad Nacional de San Martín Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes using koha-testing-docker: 1. Check the advanced search in the staff interface (Search > Advanced search > More options > Language and Language of original) and OPAC (Advanced search > More options > Language) - Yiddish doesn't appear as an option. 2. Apply the patch. 3. Update the database (databaseupdate). 4. flush_memcached and restart_all 5. Yiddish now appears as a language under the staff interface and OPAC advanced search. Question: Most languages display as 'Native language name (Language name in English)', for example 'Deutsch (German)'. Yiddish only displays as 'Yiddish'. Should Yiddish also be displayed this way?
(In reply to David Nind from comment #3) > Question: > > Most languages display as 'Native language name (Language name in English)', > for example 'Deutsch (German)'. Yiddish only displays as 'Yiddish'. > > Should Yiddish also be displayed this way? Good question! This is the first time I add a language like this, and I based this on bug 15067, and picked Spanish as the basis from the install file. I noticed Spanish has more 'display languages' than others, and that's why I picked it (thinking it was a more complete example).
Created attachment 128104 [details] [review] Bug 29596: Add Yiddish language This patch adds the Yiddish language to Koha. The language codes were taken from https://www.loc.gov/standards/iso639-2/php/code_list.php Sponsored-by: Universidad Nacional de San Martín Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 128106 [details] [review] Bug 29596: Add Yiddish language This patch adds the Yiddish language to Koha. The language codes were taken from https://www.loc.gov/standards/iso639-2/php/code_list.php Sponsored-by: Universidad Nacional de San Martín Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
David, please retest now. Your question made me dig a bit further on the subject and an adjustment was needed for RTL, specifying hebrew scripts are used to write yiddish, etc. And found a bug on bug 15067, so please test on top of the latest follow-up on that bug if interested in checking the atomic update can be run many times and results will be the same (i.e. language is added only once).
I have tested on top of bug 15067. After applying 29956 I ran databaseupdate several times (x4) - this makes the language appear multiple times (x4) as well. I'm not sure that is what you meant though...
Created attachment 129974 [details] [review] Bug 29596: Add Yiddish language This patch adds the Yiddish language to Koha. The language codes were taken from https://www.loc.gov/standards/iso639-2/php/code_list.php Sponsored-by: Universidad Nacional de San Martín Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to David Nind from comment #8) > I have tested on top of bug 15067. > > After applying 29956 I ran databaseupdate several times (x4) - this makes > the language appear multiple times (x4) as well. > > I'm not sure that is what you meant though... I reproduce. I think we must have Bug 29605 to have constraints.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Enhancement, not backported to 21.05. Please ask if needed.
(In reply to Andrew Fuerste-Henry from comment #13) > Enhancement, not backported to 21.05. Please ask if needed. Please backport :-D
Pushed to 21.05.x for 21.05.12
(In reply to Kyle M Hall from comment #12) > Pushed to 21.11.x for 21.11.03 You forgot to backport the DBRev : > git ll --grep=29596 master c346481429 Bug 29596: DBRev 21.12.00.014 87621c2c89 Bug 29596: Add Yiddish language This is also missing in 21.05.x
(In reply to Fridolin Somers from comment #16) > (In reply to Kyle M Hall from comment #12) > > Pushed to 21.11.x for 21.11.03 > > You forgot to backport the DBRev : > > > git ll --grep=29596 master > c346481429 Bug 29596: DBRev 21.12.00.014 > 87621c2c89 Bug 29596: Add Yiddish language > > This is also missing in 21.05.x hi Kyle, Andrew if you commit a fix to the git repo, and tag - i will release a new package
bumping severity
I've fixed the dbrev in 21.05.x. This hasn't made it into a 21.05 package yet, so no need to release a new one to correct it.
Backported: Pushed to 20.11.x branch for 20.11.17
Yiddish also needs to be added to the translation platform, right? Because it isn't.
(In reply to Victor Grousset/tuxayo from comment #21) > Yiddish also needs to be added to the translation platform, right? Because > it isn't. Not necessarily. We only add new languages to the translation platform if someone wants to work on them, this is here was added for search in Advanced search. The other way around it's required. Every language you can translate Koha into should also be in the tables.
Thanks, it makes sense. Noted here so it could help in the future: https://wiki.koha-community.org/wiki/Translating_Koha#Adding_a_new_language
Does this need to be backported to 19.11.x?
comment 17 has been addressed. Reverting severity and status
(In reply to David Nind from comment #8) > I have tested on top of bug 15067. > > After applying 29956 I ran databaseupdate several times (x4) - this makes > the language appear multiple times (x4) as well. > > I'm not sure that is what you meant though... Having issues upgrading to 21.11.02.003 possibly related to this. "Upgrade to 21.11.02.003 [13:16:35]: Bug 29605 - Resync DB structure for existing installations ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'yi' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 738" Looking in PMA for the DB table `language_script_mapping` looks like this; language_subtag script_subtag ar Arab he Hebr yi Hebr yi Hebr yi Hebr yi Hebr yi Hebr yi Hebr yi Hebr yi Hebr I am unsure if clearing the table of multiple entries will make or brake the instance further.
(In reply to Hans Pålsson from comment #26) > (In reply to David Nind from comment #8) > > I have tested on top of bug 15067. > > > > After applying 29956 I ran databaseupdate several times (x4) - this makes > > the language appear multiple times (x4) as well. > > > > I'm not sure that is what you meant though... > > Having issues upgrading to 21.11.02.003 possibly related to this. > "Upgrade to 21.11.02.003 [13:16:35]: Bug 29605 - Resync DB structure for > existing installations > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry > 'yi' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 738" > > Looking in PMA for the DB table `language_script_mapping` looks like this; > language_subtag script_subtag > ar Arab > he Hebr > yi Hebr > yi Hebr > yi Hebr > yi Hebr > yi Hebr > yi Hebr > yi Hebr > yi Hebr > > I am unsure if clearing the table of multiple entries will make or brake the > instance further. Remove the repeated entries. You're safe.
Cleared, problem solved. Thanks!