For languages to appear in the advanced search options they must appear in the language_rfc4646_to_iso639 table. Scottish Gaelic is missing, iso639 code gd and rfc4646 code gla.
Created attachment 153728 [details] [review] Bug 34328: Add Scottish Gaelic to languages
Created attachment 153754 [details] [review] Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
WARN installer/data/mysql/atomicupdate/bug_34328.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 14)
Not seeing special handling for UTF-8 here, but it looks like it is interpreted right by the file slurping of atomicupdate.
Created attachment 153755 [details] [review] Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation.
Thanks for the signoff Marcel.. I must admit this area of Koha is a little new to me, an area I've really not dug deep in so far.. I've added a follow-up after our customer reported they still couldn't see the language in the search dropdowns and we traced it back to them running the en-GB translated interface. Is it just me, or is this a rather unmaintainable approach to this? I feel like the options in these tables are rather out of date compared to the translations we list in Pootle.. shouldn't we effectively have one description per language in pootle per language MARC supports.. ?
Katrin should know it best. And she is in cc. I agree that this is laborious.
Not idempotent ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'gd-gla' for key 'uniq_code' at /kohadevbox/koha/C4/Installer.pm line 741
Created attachment 156593 [details] [review] Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 156594 [details] [review] Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation.
Created attachment 156595 [details] [review] Bug 34328: Make update idempotent
Thank you for including the German translation! :)
Created attachment 158371 [details] [review] Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158372 [details] [review] Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158373 [details] [review] Bug 34328: Make update idempotent Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Perltidied the atomic update. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
For reference, you can find this language definitions gla/gd in : https://www.loc.gov/standards/iso639-2/php/code_list.php
Small enhancement, I choose to backport. Pushed to 23.05.x for 23.05.06
No changes to the Koha Manual needed.