Summary: | t/db_dependent/Letters.t failing on master | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Test Suite | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17971 | ||
Bug Blocks: | 18478 | ||
Attachments: |
Bug 18620 - t/db_dependent/Letters.t failing on master
Bug 18620 - t/db_dependent/Letters.t failing on master Bug 18620 - t/db_dependent/Letters.t failing on master Bug 18620 - t/db_dependent/Letters.t failing on master Bug 18620 - t/db_dependent/Letters.t failing on master |
Description
Nick Clemens (kidclamp)
2017-05-17 15:34:07 UTC
Created attachment 63502 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Created attachment 63503 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Created attachment 63507 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch> Nick, you are not fixing the issue here :) (In reply to Jonathan Druart from comment #4) > Nick, you are not fixing the issue here :) Ok, forget that! Created attachment 63628 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Adding my signoff here, I would wait for 18478 too, reverting to SO Created attachment 63733 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Nick! Depends on bug 17971 which is not part of 16.11.x |