These two fail only if SMS::Senddriver is set to email, changes will be made on bug 18478 to fix that, but prep work will be done here: # Failed test 'message marked failed if tried to send SMS message for borrower with no smsalertnumber set (bug 11208)' # Failed test 'The message should have been resent' These fail because no substitiution params are sent # Failed test 'GetPreparedLetter should return the default one if the lang parameter is not provided' # Failed test 'GetPreparedLetter should return the required notice if it exists' # Failed test 'GetPreparedLetter should return the default notice if the one required does not exist' Additionally 'GetPreparedLetter returns the content correctly' can fail on slow server because timestamp of record creation and time of test are assumed to match
Created attachment 63502 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass
Created attachment 63503 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass
Created attachment 63507 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch>
Nick, you are not fixing the issue here :)
(In reply to Jonathan Druart from comment #4) > Nick, you are not fixing the issue here :) Ok, forget that!
Waiting for bug 18478, to QA them altogether.
Created attachment 63628 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Adding my signoff here, I would wait for 18478 too, reverting to SO
Created attachment 63733 [details] [review] Bug 18620 - t/db_dependent/Letters.t failing on master To test: 1 - Set SMSSenDriver to 'Email' 2 - prove t/db_dependent/Letters.t 3 - Tests fail 4 - Apply patch 5 - prove t/db_dependent/Letters.t 6 - Less tests fail (should be 2 sms test failures) 7 - Set SMSSendDriver to another value or blank 8 - prove t/db_dependent/Letters.t 9 - Tests pass Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.05, thanks Nick!
Depends on bug 17971 which is not part of 16.11.x