Summary: | Translatability: Get rid of %%] in translation for currency.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18662, 18665 | ||
Bug Blocks: | |||
Attachments: |
Bug 18684 - Get rid of %%] in translation for currency.tt
Bug 18684 - Get rid of %%] in translation for currency.tt Bug 18684 - Get rid of %%] in translation for currency.tt Bug 18684: (followup) Move 2 closing h3 tags to end of previous lines |
Description
Marc Véron
2017-05-26 19:07:54 UTC
Created attachment 63753 [details] [review] Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Created attachment 63769 [details] [review] Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Followed test plan and it worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 64418 [details] [review] Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Followed test plan and it worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Why the closing h3 tags is on a new line? (In reply to Jonathan Druart from comment #4) > Why the closing h3 tags is on a new line? Seems to be a mistake? How do you want it fixed? Amend patch or a follow-up. follow-up please, I will squash them. Created attachment 64442 [details] [review] Bug 18684: (followup) Move 2 closing h3 tags to end of previous lines See comment #4 Pushed to master for 17.11, thanks to everybody involved! |