| Summary: | CGI::param in list context warns in updatesupplier.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, veron | 
| Version: | Main | Keywords: | Academy | 
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | 
              Bug 18716: Remove CGI::param warns from updatesupplier.pl
               Bug 18716: Remove CGI::param warns from updatesupplier.pl Bug 18716: Remove CGI::param warns from updatesupplier.pl  | 
      ||
| 
 
        
          Description
        
        
          Tomás Cohen Arazi (tcohen)
        
        
        
        
          2017-06-02 02:51:54 UTC
        
       
    Created attachment 63901 [details] [review] Bug 18716: Remove CGI::param warns from updatesupplier.pl This script floods the logs with this kind of warnings. To test: - Run: $ koha-plack-err - Edit a vendor in the acquisitions module - Save => FAIL: Logs show lots of warnings that look like: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl - Apply this patch - Run: $ restart_all $ koha-plack-err - Edit a vendor, add/delete vendor contacts => SUCESS: No more warnings - Verify editing and storing vendor contacts works as expected. - Sign off :-D Created attachment 63945 [details] [review] Bug 18716: Remove CGI::param warns from updatesupplier.pl This script floods the logs with this kind of warnings. To test: - Run: $ koha-plack-err - Edit a vendor in the acquisitions module - Save => FAIL: Logs show lots of warnings that look like: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl - Apply this patch - Run: $ restart_all $ koha-plack-err - Edit a vendor, add/delete vendor contacts => SUCESS: No more warnings - Verify editing and storing vendor contacts works as expected. - Sign off :-D Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 64147 [details] [review] Bug 18716: Remove CGI::param warns from updatesupplier.pl This script floods the logs with this kind of warnings. To test: - Run: $ koha-plack-err - Edit a vendor in the acquisitions module - Save => FAIL: Logs show lots of warnings that look like: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl - Apply this patch - Run: $ restart_all $ koha-plack-err - Edit a vendor, add/delete vendor contacts => SUCESS: No more warnings - Verify editing and storing vendor contacts works as expected. - Sign off :-D Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09.  |