Description
Nick Clemens (kidclamp)
2017-06-19 15:48:25 UTC
Created attachment 64434 [details] [review] Rancor DGI: add support for editing/searching records from import batches Add the ability to edit records in import batches Created attachment 66882 [details] [review] Bug 18823: Rancor - add support for editing/searching records from import batches Add the ability to edit records in import batches To test: 1 - Open the advanced cataloging editor 2 - Note you have options for save targets 3 - Save record in various formats and to a 'batch' 4 - Manage the batch and note your new record is included Created attachment 66883 [details] [review] Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback Created attachment 66884 [details] [review] Bug 18823: Rancor - Allow searching of batches to be enabled/disabled To test: 1 - Open advanced cataloging editor (rancor) 2 - Under settings select 'import batches' 3 - Select some branches for search and some as save targets 4 - Verify the options work as expected (Note: empty batches cannot be searched) Created attachment 66885 [details] [review] Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved Created attachment 66919 [details] [review] Bug 18823: Rancor - improve import batch search/update ISBN handling Created attachment 77240 [details] [review] Bug 18823: Rancor - add support for editing/searching records from import batches Add the ability to edit records in import batches To test: 1 - Open the advanced cataloging editor 2 - Note you have options for save targets 3 - Save record in various formats and to a 'batch' 4 - Manage the batch and note your new record is included Created attachment 77241 [details] [review] Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback Created attachment 77242 [details] [review] Bug 18823: Rancor - Allow searching of batches to be enabled/disabled To test: 1 - Open advanced cataloging editor (rancor) 2 - Under settings select 'import batches' 3 - Select some branches for search and some as save targets 4 - Verify the options work as expected (Note: empty batches cannot be searched) Created attachment 77243 [details] [review] Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved Created attachment 77244 [details] [review] Bug 18823: Rancor - improve import batch search/update ISBN handling patch did not apply :( Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc Applying: Bug 18823: Rancor - Improvements to import batch searching Applying: Bug 18823: Rancor - Allow searching of batches to be enabled/disabled fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18823: Rancor - Allow searching of batches to be enabled/disabled Created attachment 79240 [details] [review] Bug 18823: Rancor - add support for editing/searching records from import batches Add the ability to edit records in import batches To test: 1 - Open the advanced cataloging editor 2 - Note you have options for save targets 3 - Save record in various formats and to a 'batch' 4 - Manage the batch and note your new record is included Created attachment 79241 [details] [review] Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback Created attachment 79242 [details] [review] Bug 18823: Rancor - Allow searching of batches to be enabled/disabled To test: 1 - Open advanced cataloging editor (rancor) 2 - Under settings select 'import batches' 3 - Select some branches for search and some as save targets 4 - Verify the options work as expected (Note: empty batches cannot be searched) Created attachment 79243 [details] [review] Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved Created attachment 79244 [details] [review] Bug 18823: Rancor - improve import batch search/update ISBN handling Tried testing this on bywater sandbox. Steps (Browser Chrome): a. Enabled EnableAdvancedCatalogingEditor in Administration interface b. Went to Cataloging c. Clicked on "Advanced editor" button d. Browser hangs with "Loading, please wait..." Repeated on Firefox Repeated on IE Back to Chrome: a. Disabled EnableAdvancedCatalogingEditor in Administration interface b. Went to Cataloging c. Clicked on "New Record Button", selected "Default Framework" d. Browser doesn't hang. Created attachment 80519 [details] [review] Bug 18823: Refactor and fix issue with updating import batch record Rebased code with changes from Bug 19263 Added missing function from previous patch to make saves of edits to import batches Changed setting for import batches created by Rancor to 'staged' as there is no mechanism to change them from 'staging' Changes to make batch names work with single quotes "Client's Batch" Changes to fix QA tool issues (i.e. bootstrap button & undef) Tests: 1) Open advanced cataloging editor 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) not that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch 6) Make changes and verify the changes are applied (either through searching again, or through the Staged MARC management in Tools) Created attachment 80536 [details] [review] Bug 18823: Fix patch issues Tests: 1) Open advanced cataloging editor 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) not that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch 6) Make changes and verify the changes are applied (either through searching again, or through the Staged MARC management in Tools) Comment on attachment 80536 [details] [review] Bug 18823: Fix patch issues This didn't work. Created attachment 80604 [details] [review] Bug 18823: Rancor - add support for editing/searching records from import batches. Rebase. Created attachment 80606 [details] [review] Bug 1883: Improvements to import batch searching and enabled/disabled Rebase. Created attachment 80608 [details] [review] Bug 18823: Rancor - save override warnings Rebase Created attachment 80613 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Created attachment 80626 [details] [review] Bug 18823: Rancor - add support for editing/searching records from import batches Rebase. Created attachment 80627 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Created attachment 80628 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Created attachment 80637 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Created attachment 80639 [details] [review] Bug 18823: Fix regression issues with search Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Created attachment 80651 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Created attachment 80861 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Created attachment 80866 [details] [review] Bug 18823: Rancor - add support for editing/searching records Rebase. Created attachment 80868 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Created attachment 80869 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Created attachment 80870 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Created attachment 80871 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Created attachment 80872 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Created attachment 80873 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Cori Lynn, Minor requests. I am not a cataloger. I'd be happy to test, but a couple things I request: Write the test as basic and complete as you can. The more detail you can give, the more people are able to participate and follow up. I don't know off the top of my head how to open the advanced editor without some research. If you could include the steps to get there, that would be great. This is my personal bias, but anytime you can include steps that show behavior before, and then after the patch is applied, is a plus. We don't always notice what is different, especially if we don't hang out in those areas a lot. These are just minor suggestions. If I can figure out how to get there, I will certainly test what I can. Need some instructions on using the Import batch settings. I am lost. Are there specific instructions somewhere? Created attachment 80947 [details]
Testing Advanced Cataloging with Import Batches
Testing document for 18823
Thanks for the feedback, Christopher Brannon! I added a testing document that goes through a lot of testing steps, but feel free to color outside the lines as well. (In reply to Cori Lynn Arnold from comment #43) > Thanks for the feedback, Christopher Brannon! I added a testing document > that goes through a lot of testing steps, but feel free to color outside the > lines as well. Thanks for the doc! I'm a little confused on step 4 under the patch. Where do I go to click on import? I see export buttons, but no import. The Import Record button in Step 4 is on the Advanced Editor interface: https://paste.pics/3XOYD Created attachment 85355 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Created attachment 85356 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Created attachment 85357 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Created attachment 85358 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Created attachment 85359 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Hello Cori, I have rebased this patches. Thanks for the testing documentation, very useful! I have some questions: 1) when i clean an import batch created in Rancor from Staged MARC management page, it disappears from import batches table in advanced editor. Wanted behavior ? 2) Searchable/Save target properties are lost after leaving the advanced editor. Also wanted behavior ? I can patch this if needed. Tell me your opinion. Created attachment 85376 [details]
Save To Box Issue
Save to box not working as expected
Hi Alex! > 1) when i clean an import batch created in Rancor from Staged MARC > management page, it disappears from import batches table in advanced editor. > Wanted behavior ? No, clean and empty import batches should show up on the advanced editor. > 2) Searchable/Save target properties are lost after leaving the advanced > editor. Also wanted behavior ? No, the check boxes should remain as set by the cataloger. Also, I've included a .pdf detailing issues with the Save to box and cataloger workflow that we discussed with Paul back in October. As discussed in previous comments. (In reply to Cori Lynn Arnold from comment #52) > Created attachment 85376 [details] > Save To Box Issue > > > Save to box not working as expected "After the record is created, the Batch is still selected, along with the record in the batch, enabling the cataloger to make updates to the record in the batch (this should not duplicate the record)" Is it an issue you have encountered or the behavior you would like ? I can't reproduce: - Created a batch named Oct_FAW - Search for a record and import it - Check Oct_FAW in the "Save to" list - Save - "Batch: Oct_FAW" is not checked - "Oct_FAW: #<id>" is still checked If the Batch was checked, clicking on save again would raise an error of duplicate id. "If the cataloger uses the “Advanced Search” or selects the “New Record” or “Import Record” button, the “Save to” interface should return to only having the Batch selected, and should not contain any record #s:" Right. Currently the previous <batch_name>: #<id> is still selected. Not the good behavior. But which Batch we should select. The last we saved a record ? As discussed over IRC: 1. A batch should never be automatically unchecked by the system. It should remain checked through the whole process until a cataloger unchecks the batch. 2. If a batch and a specific ID is checked, then saving the record will overwrite the record with that ID, it will not duplicate the record. Created attachment 85719 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Created attachment 85720 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. In order to test this I clicked around a bunch everything looked good. Then went through a “normal” cataloging process for our company and found an issue. 1. Start by importing a batch of records. [We do some pre-processing here that does 75% of the copy cataloging pieces automagically] So I went to Tools->Stage records for import 2. Once this is complete, I go to Settings->Import batches and see that the batch shows up in “Import Batches” Yay! 3. I select this batch to be searchable, but not a save target. I want my records to go into FAW (the client that I’m cataloging for) https://paste.pics/fb6948f2a662bd927011008d40993c0c 4. I search for the record I want to catalog for FAW. Yay! It comes up! So I hit “Import” 5. I make the required changes *Problem* Though the batch is set as _unchecked_ for “Save Target” it is automatically selected for “Save to:” https://paste.pics/fc0f4afded30ad1d83ff94188578742e Created attachment 85785 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets (In reply to Cori Lynn Arnold from comment #59) > *Problem* Though the batch is set as _unchecked_ for “Save Target” it is > automatically selected for “Save to:” > > https://paste.pics/fc0f4afded30ad1d83ff94188578742e The last patch should solve the problem. Please test. Interface fails when updating an existing record. Steps: 1. Create an import batch named "18823 Testing" using the Advanced editor under Settings -> Import Batches. Make the import batch searchable and a save target. 2. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "18823 Testing" import batch. 3. Realize that you are only human and made a mistake on the first record in the title. Now you want the title of the first record to be "Pen Ultimate Test" Search for the first record using the keyword search box and enter "Penultimate Test" and having your "18823 Testing" checked in the search. Find the record you created in step 2. Select "Import" (or "Substitute" at this point I do not know the difference??) 4. Update the title to "Pen Ultimate Test" 5. Hit "Save" Error: https://paste.pics/0bf7411510f2bb31b560da96291a3766 Control Number Conflict "Cannot Save" Expected: System to recognize that we imported the record from the same batch we are updating and to override the old record with the new one with the title changed. Catalogers (like developers) must be able to fix mistakes :) While I understand the control number conflict, if one is searching from the batch of which we are saving then the save should over-ride the record. If we use the "Save overriding warnings" option, then the record is duplicated in the import batch. (In reply to Cori Lynn Arnold from comment #62) > 4. Update the title to "Pen Ultimate Test" > > 5. Hit "Save" > > Error: https://paste.pics/0bf7411510f2bb31b560da96291a3766 > > Control Number Conflict "Cannot Save" Good catch. Side effect of the last patch. Fix is coming. Created attachment 85828 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Can't search the import batch I just created and added two records to. Steps to reproduce: 1. Create a new import batch (Settings->Import batches...) called "New Batch" 2. Make "New Batch" searchable and a save target https://paste.pics/300ea164128d55e87c65652f1abd6223 3. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "New Batch" import batch. 4. Search using the left hand search area for "Penultimate Test" in keywords Expected: "New Batch" is listed as a searchable target. Result: "New Batch" is not listed as a searchable target. https://paste.pics/33d5257511e53ee1d46722c1b1a8cece Created attachment 86087 [details] [review] Bug 18823: Fix targets registering Created attachment 86173 [details] [review] Bug 21720: Update Tests AddIssuing charge is always called in void context, but the tests checked that the return value was a Koha::Account::Offset and we now return a Koha::Account::Line. This patch changes the test to accept a Koha::Account::Line as returned, adds a test to ensure a Koha::Account::Offset is also created and corrects the logic that tests that only one accountline is added. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86174 [details] [review] Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86175 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86176 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86177 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86178 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86179 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86180 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86181 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86182 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Created attachment 86183 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> Looks great! Worked with it for an hour cataloging :) -cori lynn Bug 21720: Update Tests Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Make these two patches obsolete since they're not part of this enhancement. Created attachment 86791 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86792 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86793 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86794 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86795 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86796 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86797 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86798 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 86799 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Starting with a first code review and the tests. All in all this is quite a MASSSIVE patch. 12 files changed, 992 insertions(+), 156 deletions(-) I can't shake the feeling that this should have been broken up into smaller patches in a dependency tree. 1) QA test tools a) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc FAIL filters missing_filter at line 807 ( Preferences.Save( [% loggelogged_in_user.borrowernumber %] );) missing_filter at line 45 ( name: _("Batch: ") + `[% batch.file_name %]`,) missing_filter at line 44 ( 'batch:[% batch.import_batch_id %]': {) missing_filter at line 327 ( [% batch.import_batch_id %]: {) missing_filter at line 328 ( 'name': `[% batch.file_name %]`,) b) FAIL C4/Biblio.pm FAIL pod coverage POD is missing for 'UpdateMarcTimestamp' 2) Unit tests There are no unit tests included in this patch, but it touches a lot of methods: a) New method C4/Biblio Upate005Time is untested - I can see it's just a copy of existing code tho. b) New method C4/ImportBatch _get_import_record_timestamp is untested and should have POD. c) Changes to existing methods are not accompanied by tests: - _update_import_record_marc - _add_biblio_fields c) Changes to Koha/MetaSearcher are untested. d) New svc/cataloguing/import_batches is untested. e) New svc/cataloguing/metasearch 3) Question +use C4::Koha qw(); # Purely for GetNormalizedISBN Why not list the method inside qw if only GetNormalizedISBN is needed? 4) Can you point me to the most current and complete test plan? (including Controlnumber handling etc.) 5) Some first notes from GUI testing a) I am not completely sold on the placement of the 'Save to' box. It already looks a bit 'squashed' and it will look worse in other languages (being German I know our words for things tend to be longer) b) Main issue: Should we not preselect something or at least remember what was selected? I think 'Save to catalog' would probably the most common for normal cataloguing. Once saved for the first time, both: 'new record' and 'catalog record #' are checked. I'd expect it to create a duplicate in that case. (blocker for me - please check) c) When a record is saved, the message appears no longer centered, but far to the right. I think it's easier to miss this way. d) The modal for 'Import batches...' covers the whole screen. Changing something there will take immediate effect. I wonder if a close button would help usability or just making the modal a little smaller. e) Why is it 'Save as MARC' but 'New MARCXML'? e) When checking both, only the MARCXML is saved. I think maybe multi-select should not allowed or should be handled? Created attachment 88417 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88418 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88419 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88420 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88421 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88422 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88423 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88424 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88425 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88426 [details] [review] Bug 18823: Add pod for UpdateMarcTimestamp and template filters Created attachment 88427 [details] [review] Bug 18823: add unit tests for added/changed subroutines Created attachment 88428 [details] [review] Bug 18823: C4::Koha::GetNormalizedISBN loading Created attachment 88429 [details] [review] Bug 18823: center sucess saving message Created attachment 88430 [details] [review] Bug 18823: reduce batches management modal Created attachment 88431 [details] [review] Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC Created attachment 88432 [details] [review] Bug 18823: Don't keep record number checked after saving (In reply to Katrin Fischer from comment #89) > > 2) Unit tests > > c) Changes to Koha/MetaSearcher are untested. > d) New svc/cataloguing/import_batches is untested. > e) New svc/cataloguing/metasearch As far as i know, we don't test scripts in svc (currently 0 test). I'm not aware of a valid method to do that. About Koha/MetaSearcher. I started writing units tests but i encountered a problem: The method in charge of searching use forked process. That make the db context set in UT lost. The only way i found to make it works: commit all db changes. But this is quite unsafe. > > 5) Some first notes from GUI testing > > a) I am not completely sold on the placement of the 'Save to' box. It > already looks a bit 'squashed' and it will look worse in other languages > (being German I know our words for things tend to be longer) > I also have long batch names. But i believe text is properly handle with line returns. And i think this box positioning/sizing is consistent with the search one. Maybe you/someone can do a better proposal I think all the rest is fixed or improved. Put this back to needs signoff since there is some behavior changes Created attachment 88493 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88494 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88495 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88496 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88497 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88498 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88499 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88500 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88501 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 88502 [details] [review] Bug 18823: Add pod for UpdateMarcTimestamp and template filters Created attachment 88503 [details] [review] Bug 18823: add unit tests for added/changed subroutines Created attachment 88504 [details] [review] Bug 18823: C4::Koha::GetNormalizedISBN loading Created attachment 88505 [details] [review] Bug 18823: center sucess saving message Created attachment 88506 [details] [review] Bug 18823: reduce batches management modal Created attachment 88507 [details] [review] Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC Created attachment 88508 [details] [review] Bug 18823: Don't keep record number checked after saving Cannot update record Steps: 0. Create an import batch for "Saving / Searching" 1. Search for a title: "Machine Man by Max Barry" 2. Click "Import" 3. Check the box for your import batch in step 0. 4. Hit "Save" 5. Change the publisher to "TEST OF CHANGE TO PUBLISHER" 6. Hit "Save" 7. Error "Conflict Error Cannot Save" Expected result: a. Update the record with the same controlNum Catalogers make mistakes, we must be able to fix them. This is a consequence of removing record number (the last patch). Katrin said: "Once saved for the first time, both: 'new record' and 'catalog record #' are checked. I'd expect it to create a duplicate in that case." But now i see the benefit of keeping it. After saving a record in a batch, i think there is 2 options: 1) Update the record because you made a mistake - let the "Batch: batch_name" checked, - let the "batch_name: #id" checked So that the record is updated in the batch. 2) Save a new record in the same batch from the already saved record - make a few changes on record - let the "Batch: batch_name" checked, - uncheck "batch_name: #id" New record saved So, let the record number seems to fix the problem. Are you ok with that? Alex, yes, I'm okay with that. I didn't think through the implications of getting rid of the record # in the box. -cori lynn Failed to apply: Applying: Bug 18823: Rancor - add support for editing/searching records Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/editor.pl M koha-tmpl/intranet-tmpl/prog/css/cateditor.css M koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/cateditor.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/cateditor.css Auto-merging cataloguing/editor.pl Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18823: Rancor - add support for editing/searching records The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18823-Rancor---add-support-for-editingsearchin-0J4EtP.patch Created attachment 91205 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91206 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91207 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91208 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91209 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91210 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91211 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91212 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91213 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 91214 [details] [review] Bug 18823: Add pod for UpdateMarcTimestamp and template filters Created attachment 91215 [details] [review] Bug 18823: add unit tests for added/changed subroutines Created attachment 91216 [details] [review] Bug 18823: C4::Koha::GetNormalizedISBN loading Created attachment 91217 [details] [review] Bug 18823: center sucess saving message Created attachment 91218 [details] [review] Bug 18823: reduce batches management modal Created attachment 91219 [details] [review] Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC Patches apply, but going to the advanced editor causes a javascript error that prevents the page from fully loading: Uncaught ReferenceError: insert_copyright is not defined at marc-editor.js:140 at Object.execCb (require_19.0600010.js:29) at X.check (require_19.0600010.js:18) at X.<anonymous> (require_19.0600010.js:23) at require_19.0600010.js:8 at require_19.0600010.js:23 at y (require_19.0600010.js:7) at X.emit (require_19.0600010.js:23) at X.check (require_19.0600010.js:19) at X.<anonymous> (require_19.0600010.js:23) https://snag.gy/4eWg7B.jpg using Chrome browser. Can't see this error. It seems odd to me that there is this kind of issue here (insert_copyright is not defined at marc-editor.js:140) Using chromium But i have an other error with firefox: TypeError: a.label is undefined This one prevents the editor to be loaded too. Working on first. That last error seems to be introduced by Bug 16232 Alex, I looked at bug 16232. The left hand box with the targets doesn't exist until this patch, so the issue is caused by this patch, not that one. Created attachment 92051 [details] [review] Bug 11529: (RM follow-up) Add WHILE to directive list The QA tools don't current recognise the WHILE directive used in this template update. This patch adds the keyword to the list of recognised directives and thus allows through unfiltered variables during QA runs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Two minor issues: First: The drop-down portion of the save button isn't in-line with the rest of the button https://paste.pics/84b44eda4c05379bcc729c1884d1a292 Second: Checking the "Searchable?" checkbox in the import batches popup seems to have no effect on the search box searching. To recreate: 1. Create an import batch, make it searchable / save target 2. Save a record to the import batch 3. Search for the record using the left-hand search box (i.e. not advanced), verify it appears in the import batch 4. Uncheck the box for "Searchable" in the import batch screen 5. Search for the record using the left-hand search box, the import batch is searched Created attachment 92120 [details] [review] Bug 18823: Fix save button size and show searchable backends only in search result Created attachment 92124 [details] [review] Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Minor conflict from new clipboard feature on rancor Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] ); Should be 'logged_in_user'? This is very awesome! It seems to work as expected for the most part, but I found some functional issues that I think must be addressed: After saving duplicate we should use the new record number and duplicate should be unchecked - is essentially 'Save as new'? Checking 'Catalog record ##' and 'New catalog record' would imply duplicate, but it doesn't do that - maybe we shouldn't have 'New catalog record' when editing an existing record? Similarly, saving as 'Duplicate' and 'New catalog record' creates two new records if I uncheck the current record. Saving to "Batch: test" and "test: #5" is confusing, do I need to check both? the Batch seems superfluous, I am not sure that unchecking the specific record and selecting only the batch is clear that we are creating a new record, maybe if a specific record is not checked we can show "Batch: test (new record)" The export feature is awesome - it would be nice to have this on the 'Manage staged records' page too, but not a blocker here Not a blocker, but if I revert and imported batch should I be able to manage that batch in Rancor? Similarly, if I stage a new batch I must reload rancor to be able to manage that batch Some overall GUI cleanup would be nice, but I think this can go as is with improvement later Created attachment 94436 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94437 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94438 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94439 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94440 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94441 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94442 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94443 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94444 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 94445 [details] [review] Bug 18823: Add pod for UpdateMarcTimestamp and template filters Created attachment 94446 [details] [review] Bug 18823: add unit tests for added/changed subroutines Created attachment 94447 [details] [review] Bug 18823: C4::Koha::GetNormalizedISBN loading Created attachment 94448 [details] [review] Bug 18823: center sucess saving message Created attachment 94449 [details] [review] Bug 18823: reduce batches management modal Created attachment 94450 [details] [review] Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC Created attachment 94451 [details] [review] Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Created attachment 94452 [details] [review] Bug 18823: typo on loggelogged_in_user (In reply to Nick Clemens from comment #150) > Minor conflict from new clipboard feature on rancor Rebased > > Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] ); > Should be 'logged_in_user'? Fixed > > This is very awesome! It seems to work as expected for the most part, but I > found some functional issues that I think must be addressed: > > After saving duplicate we should use the new record number and duplicate > should be unchecked - is essentially 'Save as new'? > > Checking 'Catalog record ##' and 'New catalog record' would imply duplicate, > but it doesn't do that - maybe we shouldn't have 'New catalog record' when > editing an existing record? > > Similarly, saving as 'Duplicate' and 'New catalog record' creates two new > records if I uncheck the current record. I'm quite confused with this "Duplicate" batch. It's apparently the same as "New catalog record". But "New record" almost works as we want: After saving, the new record id is checked. Almost because we may uncheck "New record" (?). At the start, the "Duplicate" batch is not intented to appear in the batch list (and so not intented to be checked). The feature come from Bug 16232 and is used from the record detail page. Bug 23436 make this batch appear properly in the lits. I'm not the initiator of this feature. So i'm listening to the librarians for how to use these "Duplicate", "New record". Feedbacks are welcome. > > Saving to "Batch: test" and "test: #5" is confusing, do I need to check > both? the Batch seems superfluous, I am not sure that unchecking the > specific record and selecting only the batch is clear that we are creating a > new record, maybe if a specific record is not checked we can show "Batch: > test (new record)" "Batch: test" is the current batch you are working on. We keep it checked so that you can create new records and save them without to re-check the batch. "test: #5" tells you are working on the record #5 saved in the test batch. If you save again a record keeping "Batch: test" and "test: #5" checked. The record is updated in the batch. If you uncheck "test: #5" and save, we try to save a new record with the same id in the batch Test => Error, duplicate id Keeping only "test: #5" checked seems also updating the record in the batch. Once again i would appreciate some feedback from Rancor users. In my opinion, this is working as we, the initiators of this feature, expect. As discussed on IRC, the use cases are that a cataloger needs to be able to save, edit, and delete records in an import batch. We (at DGI) are not sticklers on the interface or how that gets handled by the GUI, but we *need* the feature to work, and work soon. >
> At the start, the "Duplicate" batch is not intented to appear in the batch
> list (and so not intented to be checked).
> The feature come from Bug 16232 and is used from the record detail page.
> Bug 23436 make this batch appear properly in the lits.
>
> I'm not the initiator of this feature. So i'm listening to the librarians
> for how to use these "Duplicate", "New record".
> Feedbacks are welcome.
Duplicate is equivalent to "Edit as new (Duplicate)" in the old editor - so I think Duplicate and New Catalog Record can be combined to "New catalog record"
Alex, Please address Nick's comment 171 re: "Edit as new (Duplicate)" I think it's fine if we just label it that. Also, please make sure to provide a thorough test plan before sending it back to "Needs Sign Off" Thanks! -cori lynn Created attachment 99092 [details] [review] Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99093 [details] [review] Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99094 [details] [review] Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99095 [details] [review] Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99096 [details] [review] Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99097 [details] [review] Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99098 [details] [review] Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99099 [details] [review] Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99100 [details] [review] Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> Created attachment 99101 [details] [review] Bug 18823: Add pod for UpdateMarcTimestamp and template filters Created attachment 99102 [details] [review] Bug 18823: add unit tests for added/changed subroutines Created attachment 99103 [details] [review] Bug 18823: C4::Koha::GetNormalizedISBN loading Created attachment 99104 [details] [review] Bug 18823: center sucess saving message Created attachment 99105 [details] [review] Bug 18823: reduce batches management modal Created attachment 99106 [details] [review] Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC Created attachment 99107 [details] [review] Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Created attachment 99108 [details] [review] Bug 18823: typo on loggelogged_in_user Created attachment 99109 [details] [review] Bug 18823: combine Duplicate and New Catalog Record save targets All patches are rebased. Added a new patch to combine "Duplicate" and "New Catalog Record" save targets? I wasn't able to apply these to master. |