Bug 18823 - Advanced editor - Rancor - add ability to edit records in import batches
Summary: Advanced editor - Rancor - add ability to edit records in import batches
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 10 votes (vote)
Target Milestone: ---
Assignee: Cori Lynn Arnold
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 19263
Blocks: 19265 19269
  Show dependency treegraph
 
Reported: 2017-06-19 15:48 UTC by Nick Clemens
Modified: 2019-03-16 10:35 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Rancor DGI: add support for editing/searching records from import batches (37.44 KB, patch)
2017-06-19 15:49 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records from import batches (44.62 KB, patch)
2017-09-06 14:38 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Improvements to import batch searching (20.37 KB, patch)
2017-09-06 14:38 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled (10.36 KB, patch)
2017-09-06 14:38 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Save overriding warnings (6.99 KB, patch)
2017-09-06 14:38 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - improve import batch search/update ISBN handling (2.26 KB, patch)
2017-09-07 09:59 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records from import batches (43.23 KB, patch)
2018-07-24 16:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Improvements to import batch searching (20.37 KB, patch)
2018-07-24 16:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled (10.36 KB, patch)
2018-07-24 16:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Save overriding warnings (5.38 KB, patch)
2018-07-24 16:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - improve import batch search/update ISBN handling (2.26 KB, patch)
2018-07-24 16:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records from import batches (43.25 KB, patch)
2018-09-21 17:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Improvements to import batch searching (20.37 KB, patch)
2018-09-21 17:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled (10.38 KB, patch)
2018-09-21 17:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - Save overriding warnings (5.38 KB, patch)
2018-09-21 17:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Rancor - improve import batch search/update ISBN handling (2.26 KB, patch)
2018-09-21 17:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18823: Refactor and fix issue with updating import batch record (7.00 KB, patch)
2018-10-12 15:13 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Fix patch issues (2.25 KB, patch)
2018-10-12 16:09 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records from import batches. (42.92 KB, patch)
2018-10-15 14:26 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 1883: Improvements to import batch searching and enabled/disabled (34.30 KB, patch)
2018-10-15 14:47 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - save override warnings (5.19 KB, patch)
2018-10-15 15:26 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - improve batch search/update ISBN handling (8.07 KB, patch)
2018-10-15 16:03 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records from import batches (42.92 KB, patch)
2018-10-15 18:01 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Improvements to import batch searching and enabled/disabled (29.42 KB, patch)
2018-10-15 18:12 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - save override warnings (5.19 KB, patch)
2018-10-15 18:18 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - improve batch search/update ISBN handling (8.03 KB, patch)
2018-10-15 19:17 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Fix regression issues with search (1.33 KB, patch)
2018-10-15 19:59 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Search improvements (1.45 KB, patch)
2018-10-16 13:00 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Search improvements (1.45 KB, patch)
2018-10-18 15:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records (44.48 KB, patch)
2018-10-18 17:05 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records (42.47 KB, patch)
2018-10-18 17:32 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records (42.47 KB, patch)
2018-10-18 17:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Improvements to import batch searching and enabled/disabled (29.42 KB, patch)
2018-10-18 17:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - save override warnings (5.19 KB, patch)
2018-10-18 17:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Rancor - improve batch search/update ISBN handling (8.03 KB, patch)
2018-10-18 17:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 18823: Search improvements (1.45 KB, patch)
2018-10-18 17:49 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Testing Advanced Cataloging with Import Batches (264.60 KB, application/pdf)
2018-10-19 16:30 UTC, Cori Lynn Arnold
Details
Bug 18823: Rancor - add support for editing/searching records (42.42 KB, patch)
2019-02-20 14:07 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Improvements to import batch searching and enabled/disabled (28.90 KB, patch)
2019-02-20 14:07 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Rancor - save override warnings (5.18 KB, patch)
2019-02-20 14:08 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Rancor - improve batch search/update ISBN handling (8.00 KB, patch)
2019-02-20 14:08 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Search improvements (1.45 KB, patch)
2019-02-20 14:08 UTC, Alex Arnaud
Details | Diff | Splinter Review
Save To Box Issue (107.27 KB, application/pdf)
2019-02-20 16:09 UTC, Cori Lynn Arnold
Details
Bug 18823: Keep Batch selected and remove record backends when needed. (4.95 KB, patch)
2019-02-26 14:00 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Check Batch and Record save target when importing a record from a batch. (1.22 KB, patch)
2019-02-26 14:00 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Don't show/check batch that are not enabled for saved targets (2.14 KB, patch)
2019-02-27 15:44 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Don't show/check batch that are not enabled for saved targets (2.15 KB, patch)
2019-02-28 11:07 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 18823: Fix targets registering (2.16 KB, patch)
2019-03-05 15:04 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 21720: Update Tests (2.44 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs (921 bytes, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Rancor - add support for editing/searching records (42.52 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Improvements to import batch searching and enabled/disabled (28.98 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Rancor - save override warnings (5.24 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Rancor - improve batch search/update ISBN handling (8.08 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Search improvements (1.50 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Keep Batch selected and remove record backends when needed. (5.00 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Check Batch and Record save target when importing a record from a batch. (1.27 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Don't show/check batch that are not enabled for saved targets (2.20 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 18823: Fix targets registering (2.21 KB, patch)
2019-03-06 14:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-06-19 15:48:25 UTC
These patches allow the use of import batches as targets in the advanced editor
Comment 1 Nick Clemens 2017-06-19 15:49:11 UTC
Created attachment 64434 [details] [review]
Rancor DGI: add support for editing/searching records from import batches

Add the ability to edit records in import batches
Comment 2 Nick Clemens 2017-09-06 14:38:34 UTC
Created attachment 66882 [details] [review]
Bug 18823: Rancor - add support for editing/searching records from import batches

Add the ability to edit records in import batches

To test:
1 - Open the advanced cataloging editor
2 - Note you have options for save targets
3 - Save record in various formats and to a 'batch'
4 - Manage the batch and note your new record is included
Comment 3 Nick Clemens 2017-09-06 14:38:37 UTC
Created attachment 66883 [details] [review]
Bug 18823: Rancor - Improvements to import batch searching

Refactoring and improving feedback
Comment 4 Nick Clemens 2017-09-06 14:38:39 UTC
Created attachment 66884 [details] [review]
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled

To test:
1 - Open advanced cataloging editor (rancor)
2 - Under settings select 'import batches'
3 - Select some branches for search and some as save targets
4 - Verify the options work as expected
(Note: empty batches cannot be searched)
Comment 5 Nick Clemens 2017-09-06 14:38:41 UTC
Created attachment 66885 [details] [review]
Bug 18823: Rancor - Save overriding warnings

Allow saving of record even if invalid

To test:
Open/create a record with missing mandatory fields
Click save
Record is not saved and errors are listed
Choose the dropdown under the save button and select 'Save overriding
warnings'
Note record is saved
Comment 6 Nick Clemens 2017-09-07 09:59:19 UTC
Created attachment 66919 [details] [review]
Bug 18823: Rancor - improve import batch search/update ISBN handling
Comment 7 Nick Clemens 2018-07-24 16:54:49 UTC
Created attachment 77240 [details] [review]
Bug 18823: Rancor - add support for editing/searching records from import batches

Add the ability to edit records in import batches

To test:
1 - Open the advanced cataloging editor
2 - Note you have options for save targets
3 - Save record in various formats and to a 'batch'
4 - Manage the batch and note your new record is included
Comment 8 Nick Clemens 2018-07-24 16:54:52 UTC
Created attachment 77241 [details] [review]
Bug 18823: Rancor - Improvements to import batch searching

Refactoring and improving feedback
Comment 9 Nick Clemens 2018-07-24 16:54:56 UTC
Created attachment 77242 [details] [review]
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled

To test:
1 - Open advanced cataloging editor (rancor)
2 - Under settings select 'import batches'
3 - Select some branches for search and some as save targets
4 - Verify the options work as expected
(Note: empty batches cannot be searched)
Comment 10 Nick Clemens 2018-07-24 16:54:59 UTC
Created attachment 77243 [details] [review]
Bug 18823: Rancor - Save overriding warnings

Allow saving of record even if invalid

To test:
Open/create a record with missing mandatory fields
Click save
Record is not saved and errors are listed
Choose the dropdown under the save button and select 'Save overriding
warnings'
Note record is saved
Comment 11 Nick Clemens 2018-07-24 16:55:02 UTC
Created attachment 77244 [details] [review]
Bug 18823: Rancor - improve import batch search/update ISBN handling
Comment 12 Claire Gravely 2018-08-22 12:01:20 UTC
patch did not apply :( 

Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
M	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
Applying: Bug 18823: Rancor - Improvements to import batch searching
Applying: Bug 18823: Rancor - Allow searching of batches to be enabled/disabled
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 18823: Rancor - Allow searching of batches to be enabled/disabled
Comment 13 Nick Clemens 2018-09-21 17:26:20 UTC
Created attachment 79240 [details] [review]
Bug 18823: Rancor - add support for editing/searching records from import batches

Add the ability to edit records in import batches

To test:
1 - Open the advanced cataloging editor
2 - Note you have options for save targets
3 - Save record in various formats and to a 'batch'
4 - Manage the batch and note your new record is included
Comment 14 Nick Clemens 2018-09-21 17:26:23 UTC
Created attachment 79241 [details] [review]
Bug 18823: Rancor - Improvements to import batch searching

Refactoring and improving feedback
Comment 15 Nick Clemens 2018-09-21 17:26:27 UTC
Created attachment 79242 [details] [review]
Bug 18823: Rancor - Allow searching of batches to be enabled/disabled

To test:
1 - Open advanced cataloging editor (rancor)
2 - Under settings select 'import batches'
3 - Select some branches for search and some as save targets
4 - Verify the options work as expected
(Note: empty batches cannot be searched)
Comment 16 Nick Clemens 2018-09-21 17:26:31 UTC
Created attachment 79243 [details] [review]
Bug 18823: Rancor - Save overriding warnings

Allow saving of record even if invalid

To test:
Open/create a record with missing mandatory fields
Click save
Record is not saved and errors are listed
Choose the dropdown under the save button and select 'Save overriding
warnings'
Note record is saved
Comment 17 Nick Clemens 2018-09-21 17:26:34 UTC
Created attachment 79244 [details] [review]
Bug 18823: Rancor - improve import batch search/update ISBN handling
Comment 18 Cori Lynn Arnold 2018-10-05 16:11:42 UTC
Tried testing this on bywater sandbox.

Steps (Browser Chrome): 

a. Enabled EnableAdvancedCatalogingEditor in Administration interface
b. Went to Cataloging
c. Clicked on "Advanced editor" button
d. Browser hangs with "Loading, please wait..."

Repeated on Firefox
Repeated on IE

Back to Chrome:
a. Disabled EnableAdvancedCatalogingEditor in Administration interface
b. Went to Cataloging
c. Clicked on "New Record Button", selected "Default Framework"
d. Browser doesn't hang.
Comment 19 Cori Lynn Arnold 2018-10-12 15:13:14 UTC
Created attachment 80519 [details] [review]
Bug 18823: Refactor and fix issue with updating import batch record

Rebased code with changes from Bug 19263
Added missing function from previous patch to make saves of edits to
import batches
Changed setting for import batches created by Rancor to 'staged' as
there is no mechanism to change them from 'staging'
Changes to make batch names work with single quotes "Client's Batch"
Changes to fix QA tool issues (i.e. bootstrap button & undef)

Tests:

1) Open advanced cataloging editor
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) not that import batches for saving appear on the left side as
    targets to save
4) Search for a bibliographic record, make changes and apply to an
import batch
5) Search for the bibliographic record in the import batch
6) Make changes and verify the changes are applied (either through
    searching again, or through the Staged MARC management in Tools)
Comment 20 Cori Lynn Arnold 2018-10-12 16:09:12 UTC
Created attachment 80536 [details] [review]
Bug 18823: Fix patch issues

Tests:

1) Open advanced cataloging editor
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
        3.a) not that import batches for saving appear on the left side
        as targets to save
4) Search for a bibliographic record, make changes and apply to an
        import batch
5) Search for the bibliographic record in the import batch
6) Make changes and verify the changes are applied (either
        through searching again, or through the Staged MARC
        management in Tools)
Comment 21 Cori Lynn Arnold 2018-10-12 16:38:49 UTC
Comment on attachment 80536 [details] [review]
Bug 18823: Fix patch issues

This didn't work.
Comment 22 Cori Lynn Arnold 2018-10-15 14:26:33 UTC
Created attachment 80604 [details] [review]
Bug 18823: Rancor - add support for editing/searching records from import batches.

Rebase.
Comment 23 Cori Lynn Arnold 2018-10-15 14:47:16 UTC
Created attachment 80606 [details] [review]
Bug 1883: Improvements to import batch searching and enabled/disabled

Rebase.
Comment 24 Cori Lynn Arnold 2018-10-15 15:26:40 UTC
Created attachment 80608 [details] [review]
Bug 18823: Rancor - save override warnings

Rebase
Comment 25 Cori Lynn Arnold 2018-10-15 16:03:46 UTC
Created attachment 80613 [details] [review]
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase
Comment 26 Cori Lynn Arnold 2018-10-15 18:01:47 UTC
Created attachment 80626 [details] [review]
Bug 18823: Rancor - add support for editing/searching records from import batches

Rebase.
Comment 27 Cori Lynn Arnold 2018-10-15 18:12:11 UTC
Created attachment 80627 [details] [review]
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.
Comment 28 Cori Lynn Arnold 2018-10-15 18:18:39 UTC
Created attachment 80628 [details] [review]
Bug 18823: Rancor - save override warnings

Rebase.
Comment 29 Cori Lynn Arnold 2018-10-15 19:17:46 UTC
Created attachment 80637 [details] [review]
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase
Comment 30 Cori Lynn Arnold 2018-10-15 19:59:24 UTC
Created attachment 80639 [details] [review]
Bug 18823: Fix regression issues with search

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets (and some both)
     3.a) note that import batches for saving appear on the left side as targets to save
4) Search for a bibliographic record, make changes and apply to an import batch
5) Search for the bibliographic record in the import batch by author, title, isbn
6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools)
Comment 31 Cori Lynn Arnold 2018-10-16 13:00:07 UTC
Created attachment 80651 [details] [review]
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) note that import batches for saving appear on the left
         side as targets to save
4) Search for a bibliographic record, make changes and apply to
     an import batch
5) Search for the bibliographic record in the import batch by
     author, title, isbn
6) Make changes to the import batch records and verify the
     changes are applied (either through searching again, or through
     the Staged MARC management page in Tools)
Comment 32 Cori Lynn Arnold 2018-10-18 15:49:55 UTC
Created attachment 80861 [details] [review]
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) note that import batches for saving appear on the left
         side as targets to save
4) Search for a bibliographic record, make changes and apply to
     an import batch
5) Search for the bibliographic record in the import batch by
     author, title, isbn
6) Make changes to the import batch records and verify the
     changes are applied (either through searching again, or through
     the Staged MARC management page in Tools)
Comment 33 Cori Lynn Arnold 2018-10-18 17:05:17 UTC
Created attachment 80866 [details] [review]
Bug 18823: Rancor - add support for editing/searching records

Rebase.
Comment 34 Cori Lynn Arnold 2018-10-18 17:32:56 UTC
Created attachment 80868 [details] [review]
Bug 18823: Rancor - add support for editing/searching records

rebase.
Comment 35 Cori Lynn Arnold 2018-10-18 17:49:08 UTC
Created attachment 80869 [details] [review]
Bug 18823: Rancor - add support for editing/searching records

rebase.
Comment 36 Cori Lynn Arnold 2018-10-18 17:49:12 UTC
Created attachment 80870 [details] [review]
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.
Comment 37 Cori Lynn Arnold 2018-10-18 17:49:17 UTC
Created attachment 80871 [details] [review]
Bug 18823: Rancor - save override warnings

Rebase.
Comment 38 Cori Lynn Arnold 2018-10-18 17:49:20 UTC
Created attachment 80872 [details] [review]
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase
Comment 39 Cori Lynn Arnold 2018-10-18 17:49:25 UTC
Created attachment 80873 [details] [review]
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) note that import batches for saving appear on the left
         side as targets to save
4) Search for a bibliographic record, make changes and apply to
     an import batch
5) Search for the bibliographic record in the import batch by
     author, title, isbn
6) Make changes to the import batch records and verify the
     changes are applied (either through searching again, or through
     the Staged MARC management page in Tools)
Comment 40 Christopher Brannon 2018-10-18 22:45:24 UTC
Cori Lynn,
Minor requests.  I am not a cataloger.  I'd be happy to test, but a couple things I request:

Write the test as basic and complete as you can.  The more detail you can give, the more people are able to participate and follow up.

I don't know off the top of my head how to open the advanced editor without some research.  If you could include the steps to get there, that would be great.

This is my personal bias, but anytime you can include steps that show behavior before, and then after the patch is applied, is a plus.  We don't always notice what is different, especially if we don't hang out in those areas a lot.

These are just minor suggestions.  If I can figure out how to get there, I will certainly test what I can.
Comment 41 Christopher Brannon 2018-10-18 23:09:26 UTC
Need some instructions on using the Import batch settings.  I am lost.  Are there specific instructions somewhere?
Comment 42 Cori Lynn Arnold 2018-10-19 16:30:16 UTC
Created attachment 80947 [details]
Testing Advanced Cataloging with Import Batches

Testing document for 18823
Comment 43 Cori Lynn Arnold 2018-10-19 16:37:26 UTC
Thanks for the feedback, Christopher Brannon! I added a testing document that goes through a lot of testing steps, but feel free to color outside the lines as well.
Comment 44 Christopher Brannon 2018-10-19 17:45:04 UTC
(In reply to Cori Lynn Arnold from comment #43)
> Thanks for the feedback, Christopher Brannon! I added a testing document
> that goes through a lot of testing steps, but feel free to color outside the
> lines as well.

Thanks for the doc!  I'm a little confused on step 4 under the patch.  Where do I go to click on import?  I see export buttons, but no import.
Comment 45 Cori Lynn Arnold 2018-10-19 19:41:54 UTC
The Import Record button in Step 4 is on the Advanced Editor interface:

https://paste.pics/3XOYD
Comment 46 Alex Arnaud 2019-02-20 14:07:53 UTC
Created attachment 85355 [details] [review]
Bug 18823: Rancor - add support for editing/searching records

rebase.
Comment 47 Alex Arnaud 2019-02-20 14:07:58 UTC
Created attachment 85356 [details] [review]
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.
Comment 48 Alex Arnaud 2019-02-20 14:08:02 UTC
Created attachment 85357 [details] [review]
Bug 18823: Rancor - save override warnings

Rebase.
Comment 49 Alex Arnaud 2019-02-20 14:08:06 UTC
Created attachment 85358 [details] [review]
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase
Comment 50 Alex Arnaud 2019-02-20 14:08:10 UTC
Created attachment 85359 [details] [review]
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) note that import batches for saving appear on the left
         side as targets to save
4) Search for a bibliographic record, make changes and apply to
     an import batch
5) Search for the bibliographic record in the import batch by
     author, title, isbn
6) Make changes to the import batch records and verify the
     changes are applied (either through searching again, or through
     the Staged MARC management page in Tools)
Comment 51 Alex Arnaud 2019-02-20 14:14:11 UTC
Hello Cori,

I have rebased this patches. Thanks for the testing documentation, very useful!

I have some questions:
1) when i clean an import batch created in Rancor from Staged MARC management page, it disappears from import batches table in advanced editor. Wanted behavior ?

2) Searchable/Save target properties are lost after leaving the advanced editor. Also wanted behavior ?

I can patch this if needed. Tell me your opinion.
Comment 52 Cori Lynn Arnold 2019-02-20 16:09:09 UTC
Created attachment 85376 [details]
Save To Box Issue


Save to box not working as expected
Comment 53 Cori Lynn Arnold 2019-02-20 16:30:01 UTC
Hi Alex!

> 1) when i clean an import batch created in Rancor from Staged MARC
> management page, it disappears from import batches table in advanced editor.
> Wanted behavior ?

No, clean and empty import batches should show up on the advanced editor.

> 2) Searchable/Save target properties are lost after leaving the advanced
> editor. Also wanted behavior ?

No, the check boxes should remain as set by the cataloger.

Also, I've included a .pdf detailing issues with the Save to box and cataloger workflow that we discussed with Paul back in October.
Comment 54 Cori Lynn Arnold 2019-02-20 16:39:27 UTC
As discussed in previous comments.
Comment 55 Alex Arnaud 2019-02-21 16:14:50 UTC
(In reply to Cori Lynn Arnold from comment #52)
> Created attachment 85376 [details]
> Save To Box Issue
> 
> 
> Save to box not working as expected

"After the record is created, the Batch is still selected, along with the record in the batch, enabling the
cataloger to make updates to the record in the batch (this should not duplicate the record)"

Is it an issue you have encountered or the behavior you would like ?
I can't reproduce:
 - Created a batch named Oct_FAW
 - Search for a record and import it
 - Check Oct_FAW in the "Save to" list
 - Save
 - "Batch: Oct_FAW" is not checked
 - "Oct_FAW: #<id>" is still checked

If the Batch was checked, clicking on save again would raise an error of duplicate id.

"If the cataloger uses the “Advanced Search” or selects the “New Record” or “Import Record” button, the
“Save to” interface should return to only having the Batch selected, and should not contain any record
#s:"

Right. Currently the previous <batch_name>: #<id> is still selected. Not the good behavior.
But which Batch we should select. The last we saved a record ?
Comment 56 Cori Lynn Arnold 2019-02-22 13:50:48 UTC
As discussed over IRC:

1. A batch should never be automatically unchecked by the system. It should remain checked through the whole process until a cataloger unchecks the batch.
2. If a batch and a specific ID is checked, then saving the record will overwrite the record with that ID, it will not duplicate the record.
Comment 57 Alex Arnaud 2019-02-26 14:00:23 UTC
Created attachment 85719 [details] [review]
Bug 18823: Keep Batch selected and remove record backends when needed.
Comment 58 Alex Arnaud 2019-02-26 14:00:27 UTC
Created attachment 85720 [details] [review]
Bug 18823: Check Batch and Record save target when importing a record from a batch.
Comment 59 Cori Lynn Arnold 2019-02-26 14:55:40 UTC
In order to test this I clicked around a bunch everything looked good. Then went through a “normal” cataloging process for our company and found an issue.

1.	Start by importing a batch of records. [We do some pre-processing here that does 75% of the copy cataloging pieces automagically] So I went to Tools->Stage records for import
2.	Once this is complete, I go to Settings->Import batches and see that the batch shows up in “Import Batches” Yay!
3.	I select this batch to be searchable, but not a save target. I want my records to go into FAW (the client that I’m cataloging for)

https://paste.pics/fb6948f2a662bd927011008d40993c0c

4. I search for the record I want to catalog for FAW. Yay! It comes up! So I hit “Import”

5. I make the required changes

*Problem* Though the batch is set as _unchecked_ for “Save Target” it is automatically selected for “Save to:” 

https://paste.pics/fc0f4afded30ad1d83ff94188578742e
Comment 60 Alex Arnaud 2019-02-27 15:44:49 UTC
Created attachment 85785 [details] [review]
Bug 18823: Don't show/check batch that are not enabled for saved targets
Comment 61 Alex Arnaud 2019-02-27 15:46:06 UTC
(In reply to Cori Lynn Arnold from comment #59)

> *Problem* Though the batch is set as _unchecked_ for “Save Target” it is
> automatically selected for “Save to:” 
> 
> https://paste.pics/fc0f4afded30ad1d83ff94188578742e

The last patch should solve the problem. Please test.
Comment 62 Cori Lynn Arnold 2019-02-27 18:12:34 UTC
Interface fails when updating an existing record. Steps:

1. Create an import batch named "18823 Testing" using the Advanced editor under Settings -> Import Batches. Make the import batch searchable and a save target.

2. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "18823 Testing" import batch.

3. Realize that you are only human and made a mistake on the first record in the title. Now you want the title of the first record to be "Pen Ultimate Test" Search for the first record using the keyword search box and enter "Penultimate Test" and having your "18823 Testing" checked in the search. Find the record you created in step 2. Select "Import" (or "Substitute" at this point I do not know the difference??)

4. Update the title to "Pen Ultimate Test"

5. Hit "Save"

Error: https://paste.pics/0bf7411510f2bb31b560da96291a3766

Control Number Conflict "Cannot Save"

Expected: System to recognize that we imported the record from the same batch we are updating and to override the old record with the new one with the title changed.

Catalogers (like developers) must be able to fix mistakes :) While I understand the control number conflict, if one is searching from the batch of which we are saving then the save should over-ride the record. 

If we use the "Save overriding warnings" option, then the record is duplicated in the import batch.
Comment 63 Alex Arnaud 2019-02-28 11:06:11 UTC
(In reply to Cori Lynn Arnold from comment #62)

> 4. Update the title to "Pen Ultimate Test"
> 
> 5. Hit "Save"
> 
> Error: https://paste.pics/0bf7411510f2bb31b560da96291a3766
> 
> Control Number Conflict "Cannot Save"

Good catch. Side effect of the last patch. Fix is coming.
Comment 64 Alex Arnaud 2019-02-28 11:07:24 UTC
Created attachment 85828 [details] [review]
Bug 18823: Don't show/check batch that are not enabled for saved targets
Comment 65 Cori Lynn Arnold 2019-03-04 19:23:15 UTC
Can't search the import batch I just created and added two records to.

Steps to reproduce:

1. Create a new import batch (Settings->Import batches...) called "New Batch"
2. Make "New Batch" searchable and a save target

https://paste.pics/300ea164128d55e87c65652f1abd6223

3. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "New Batch" import batch.
4. Search using the left hand search area for "Penultimate Test" in keywords

Expected: "New Batch" is listed as a searchable target.

Result: "New Batch" is not listed as a searchable target.
https://paste.pics/33d5257511e53ee1d46722c1b1a8cece
Comment 66 Alex Arnaud 2019-03-05 15:04:28 UTC
Created attachment 86087 [details] [review]
Bug 18823: Fix targets registering
Comment 67 ByWater Sandboxes 2019-03-06 14:24:02 UTC
Created attachment 86173 [details] [review]
Bug 21720: Update Tests

AddIssuing charge is always called in void context, but the tests
checked that the return value was a Koha::Account::Offset and we now
return a Koha::Account::Line.

This patch changes the test to accept a Koha::Account::Line as returned,
adds a test to ensure a Koha::Account::Offset is also created and
corrects the logic that tests that only one accountline is added.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 68 ByWater Sandboxes 2019-03-06 14:24:05 UTC
Created attachment 86174 [details] [review]
Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 69 ByWater Sandboxes 2019-03-06 14:24:08 UTC
Created attachment 86175 [details] [review]
Bug 18823: Rancor - add support for editing/searching records

rebase.

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 70 ByWater Sandboxes 2019-03-06 14:24:11 UTC
Created attachment 86176 [details] [review]
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 71 ByWater Sandboxes 2019-03-06 14:24:14 UTC
Created attachment 86177 [details] [review]
Bug 18823: Rancor - save override warnings

Rebase.

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 72 ByWater Sandboxes 2019-03-06 14:24:17 UTC
Created attachment 86178 [details] [review]
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 73 ByWater Sandboxes 2019-03-06 14:24:20 UTC
Created attachment 86179 [details] [review]
Bug 18823: Search improvements

Search can now find titles and keywords with single quotes i.e. "Time
Traveler's Wife" in import batches.

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets
(and some both)
    3.a) note that import batches for saving appear on the left
         side as targets to save
4) Search for a bibliographic record, make changes and apply to
     an import batch
5) Search for the bibliographic record in the import batch by
     author, title, isbn
6) Make changes to the import batch records and verify the
     changes are applied (either through searching again, or through
     the Staged MARC management page in Tools)

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 74 ByWater Sandboxes 2019-03-06 14:24:23 UTC
Created attachment 86180 [details] [review]
Bug 18823: Keep Batch selected and remove record backends when needed.

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 75 ByWater Sandboxes 2019-03-06 14:24:26 UTC
Created attachment 86181 [details] [review]
Bug 18823: Check Batch and Record save target when importing a record from a batch.

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 76 ByWater Sandboxes 2019-03-06 14:24:28 UTC
Created attachment 86182 [details] [review]
Bug 18823: Don't show/check batch that are not enabled for saved targets

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 77 ByWater Sandboxes 2019-03-06 14:24:31 UTC
Created attachment 86183 [details] [review]
Bug 18823: Fix targets registering

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 78 Cori Lynn Arnold 2019-03-06 14:25:12 UTC
Looks great! Worked with it for an hour cataloging :)

-cori lynn