Bug 19046

Summary: IntranetCatalogSearchPulldown doesn't retain last selection
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dcook, fridolin.somers, gmcharlt, jonathan.druart, karen, katrin.fischer, lucas, martin.renvoize, pierre-marc.thibault
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14902    
Bug Blocks: 26247    
Attachments: Bug 19046: Make seach pulldown to retain index selection
Bug 19046: Make seach pulldown to retain index selection
Bug 19046: Make seach pulldown to retain index selection
Bug 19046: (QA follow-up) Remove doubled up 'Title as phrase'

Description Nick Clemens (kidclamp) 2017-08-06 09:58:40 UTC
On the OPAC if you have the pulldown enabled and perform a 'Title' search, this selection carries over. On the staff client the default is always 'Keyword'
Comment 1 Katrin Fischer 2017-08-18 16:43:21 UTC
*** Bug 19152 has been marked as a duplicate of this bug. ***
Comment 2 Karen 2017-08-18 16:45:30 UTC
One of our library partners was searching for a list of titles and wanted to use the Title option for each of her searches. She noticed that after every search she did using Title search option, the system always defaulted back to Keyword. 

The expected behavior is that the search option would stay on Title and not default back to Keyword each time.
Comment 3 Katrin Fischer 2019-02-10 18:01:14 UTC
Also the search term doesn't remain in the search box like it does in the OPAC. Still valid :(
Comment 4 Jonathan Druart 2019-03-04 18:42:18 UTC Comment hidden (obsolete)
Comment 5 Pierre-Marc Thibault 2019-03-08 20:10:26 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2019-03-09 20:50:45 UTC
Created attachment 86416 [details] [review]
Bug 19046: Make seach pulldown to retain index selection

This patch also fixes add the term in the search input

Test plan:
Enable IntranetCatalogSearchPulldown
Search for a term using the search input in the header (simple search)
Re-do selecting different indices

The selection must retain on the search result page.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2019-03-09 20:50:49 UTC
Created attachment 86417 [details] [review]
Bug 19046: (QA follow-up) Remove doubled up 'Title as phrase'

One search option was doubled up by accident.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Nick Clemens (kidclamp) 2019-03-11 13:10:49 UTC
Awesome work all!

Pushed to master for 19.05
Comment 9 Martin Renvoize 2019-03-12 08:51:38 UTC
Pushed to 18.11.x for 18.11.04
Comment 10 Lucas Gass 2019-03-15 17:31:02 UTC
backported to 18.05.x for 18.05.11
Comment 11 David Cook 2020-08-19 03:36:46 UTC
(In reply to Katrin Fischer from comment #3)
> Also the search term doesn't remain in the search box like it does in the
> OPAC. Still valid :(

This actually creates a problem in the Staff Interface. If you retain the search term in the search box, that text stays in the box if you change to "Check out" or "Check in", which means you have to manually clear the search terms before typing/scanning in a barcode.

No other module retains the text in the top search box, so I think the search module should be consistent with the behaviour across the system.
Comment 12 David Cook 2020-08-19 03:38:37 UTC
(In reply to David Cook from comment #11)
> (In reply to Katrin Fischer from comment #3)
> > Also the search term doesn't remain in the search box like it does in the
> > OPAC. Still valid :(
> 
> This actually creates a problem in the Staff Interface. If you retain the
> search term in the search box, that text stays in the box if you change to
> "Check out" or "Check in", which means you have to manually clear the search
> terms before typing/scanning in a barcode.
> 
> No other module retains the text in the top search box, so I think the
> search module should be consistent with the behaviour across the system.

Alternatively, maybe the text in the search box shouldn't be retained if it's coming from the "Search the catalog" tab...