Summary: | Show patron category description instead of code in patron batch modification list | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Tools | Assignee: | Alex Sassmannshausen <alex> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | alex, fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19074: bugfix: Dereference correct value from Koha::Object.
Bug 19074: Fix category display in Batch patron modification. [SIGNED OFF] Bug 19074: Fix category display in Batch patron modification. Bug 19074: Fix category display in Batch patron modification. Bug 19074: Do not crash if cardnumber does not exist |
Description
Katrin Fischer
2017-08-10 10:00:58 UTC
Created attachment 65798 [details] [review] Bug 19074: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated Accidentally uploaded patch to wrong bug. Alex Created attachment 65800 [details] [review] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. (In reply to Alex Sassmannshausen from comment #3) > Created attachment 65800 [details] [review] [review] > Bug 19074: Fix category display in Batch patron modification. > > * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron > category description. > * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use > it. Test Plan: - Check that patron categories display in a human friendly way throughout batch modification tool. Created attachment 65806 [details] [review] [SIGNED OFF] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 65839 [details] [review] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65840 [details] [review] Bug 19074: Do not crash if cardnumber does not exist If a cardnumber does not exist, $borrower will be undef and the ->category call will explode Can't call method "category" on an undefined value at /home/vagrant/kohaclone/tools/modborrowers.pl line 370. This patch makes sure the patron exists before calling any methods. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! |