When editing mulitple patrons unsing the patron batch modification tool, the list of patrons shows the patron category code instead of the patron category description. As the pull down below has the description, this can be quite confusing to some users and makes it harder to verify the correct results.
Created attachment 65798 [details] [review] Bug 19074: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated
Accidentally uploaded patch to wrong bug. Alex
Created attachment 65800 [details] [review] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it.
(In reply to Alex Sassmannshausen from comment #3) > Created attachment 65800 [details] [review] [review] > Bug 19074: Fix category display in Batch patron modification. > > * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron > category description. > * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use > it. Test Plan: - Check that patron categories display in a human friendly way throughout batch modification tool.
Created attachment 65806 [details] [review] [SIGNED OFF] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 65839 [details] [review] Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 65840 [details] [review] Bug 19074: Do not crash if cardnumber does not exist If a cardnumber does not exist, $borrower will be undef and the ->category call will explode Can't call method "category" on an undefined value at /home/vagrant/kohaclone/tools/modborrowers.pl line 370. This patch makes sure the patron exists before calling any methods. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Patch does not apply on 17.05.x because of Bug 17829. Since this is a minor, I propose to set as resolved.