Summary: | Remove deprecated checkouts by patron category report | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, lucas, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3431 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20092 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19669: Remove deprecated checkouts by patron category report
Bug 19669: Remove deprecated checkouts by patron category report Bug 19669: Remove deprecated checkouts by patron category report Bug 19669 [QA Followup] - Remove itemstypes.plugin |
Description
Owen Leonard
2017-11-21 13:49:57 UTC
Created attachment 69246 [details] [review] Bug 19669: Remove deprecated checkouts by patron category report The checkouts by patron category report has been hidden and considered deprecated since 2004. This patch removes it. To test, apply the patch and confirm that nothing at all seems to have changed and everything feels fine. Created attachment 69406 [details] [review] Bug 19669: Remove deprecated checkouts by patron category report Patch applies. Reports and general OPAC and staff client functionality is intact. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> *** Bug 19668 has been marked as a duplicate of this bug. *** *** Bug 19667 has been marked as a duplicate of this bug. *** *** Bug 19666 has been marked as a duplicate of this bug. *** *** Bug 19665 has been marked as a duplicate of this bug. *** What about the other .plugin file (reports/itemtypes.plugin), see bug 3431 comment 2. And then remove reports/manager.pl? Is this plugin system used? Created attachment 70029 [details] [review] Bug 19669: Remove deprecated checkouts by patron category report Patch applies. Reports and general OPAC and staff client functionality is intact. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 70030 [details] [review] Bug 19669 [QA Followup] - Remove itemstypes.plugin Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Kyle M Hall from comment #9) > Created attachment 70030 [details] [review] [review] > Bug 19669 [QA Followup] - Remove itemstypes.plugin > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Kyle, Are you sure about that? If yes we should remove it on a specific bug report, as well as the reports/manager.pl stuffs. Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 Link for reports/itemtypes.plugin is stil in staff:/cgi-bin/koha/reports/reports-home.pl with the name "Catalog by itemtype" New bug for this or do we use the current one? (In reply to Victor Grousset/tuxayo from comment #14) > Link for reports/itemtypes.plugin is stil in > staff:/cgi-bin/koha/reports/reports-home.pl > with the name "Catalog by itemtype" > > New bug for this or do we use the current one? I'd say new bug since this one has been released. (In reply to Jonathan Druart from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 70030 [details] [review] [review] [review] > > Bug 19669 [QA Followup] - Remove itemstypes.plugin > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > Kyle, Are you sure about that? > If yes we should remove it on a specific bug report, as well as the > reports/manager.pl stuffs. Oops, I forgot to remove this commit before the push, I am going to revert it. (In reply to Jonathan Druart from comment #16) > (In reply to Jonathan Druart from comment #10) > > (In reply to Kyle M Hall from comment #9) > > > Created attachment 70030 [details] [review] [review] [review] [review] > > > Bug 19669 [QA Followup] - Remove itemstypes.plugin > > > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > > > Kyle, Are you sure about that? > > If yes we should remove it on a specific bug report, as well as the > > reports/manager.pl stuffs. > > Oops, I forgot to remove this commit before the push, I am going to revert > it. Reverted last patch for stable for 17.11.03 (In reply to Nick Clemens from comment #17) > > Reverted last patch for stable for 17.11.03 Same for 17.05 then, reverted in v17.05.09 Just for anyone else who might have also a doubt: it's indeed reverted in master (commit 7cb86656956131ed81cc74069a765a37664edd8e) *** Bug 20368 has been marked as a duplicate of this bug. *** |