Description
Owen Leonard
2018-01-10 16:09:14 UTC
Created attachment 70411 [details] [review] Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better <title> handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Created attachment 70716 [details] [review] Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better <title> handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Created attachment 71204 [details] [review] Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better <title> handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Did not we agree that the action buttons should be grouped only if there are more than 2? I also see this: https://screenshots.firefox.com/jDHvackVDkBUUjlC/pro.kohadev.org (In reply to Jonathan Druart from comment #4) > Did not we agree that the action buttons should be grouped only if there are > more than 2? It is displayed when a row is clicked, so it is not valid here. Created attachment 71384 [details] [review] Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. This patch also adds some whitespace to the "Author (meeting/conference)" label to enable better word wrapping. To test, apply the patch and go to Authorities -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Created attachment 73274 [details] [review] Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. This patch also adds some whitespace to the "Author (meeting/conference)" label to enable better word wrapping. To test, apply the patch and go to Authorities -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Patch applies, form resizes, displays and functions as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 73275 [details] [review] Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better <title> handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 73276 [details] [review] Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. This patch also adds some whitespace to the "Author (meeting/conference)" label to enable better word wrapping. To test, apply the patch and go to Authorities -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Patch applies, form resizes, displays and functions as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, enhancement, not backported for stable |