Summary: | Switch single-column templates to Bootstrap grid: Course reserves | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, josef.moravec, nengard, nick, testopia, tmisilo |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 14546, 19980, 20268 | ||
Attachments: |
Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves
Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves |
Description
Owen Leonard
2018-01-16 15:02:31 UTC
Created attachment 70557 [details] [review] Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Missed: course.tt add_items-step1.tt add_items-step2.tt Created attachment 70559 [details] [review] Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. *** Bug 19848 has been marked as a duplicate of this bug. *** Created attachment 71711 [details] [review] Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71907 [details] [review] Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backported for 17.11 |