Summary: | Add column configuration to table of saved reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | axelle.clarisse, jonathan.druart, lucie.gay, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20530 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 19282, 20814 | ||
Attachments: |
Bug 20350: Add column configuration to table of saved reports
Bug 20350: Add column configuration to table of saved reports Bug 20350: Add column configuration to table of saved reports Bug 20350: Add column configuration to table of saved reports |
Description
Owen Leonard
2018-03-07 13:20:48 UTC
Created attachment 72505 [details] [review] Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Tested on sandbox Biblibre n°1 Go to Reports -> Use saved. there is not a "Column visibility" button in the table's pagination toolbar and the report groups are not correctly displayed in tabs Go to Administration -> Columns settings. - Find "id=table_reports." : OK - Make some selections to configure default settings of the reports table : OK. We selected json_url and saved_results. - these defaults were not applied. Created attachment 72652 [details] [review] Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Tested on sandbox Biblibre n°9 Go to Reports -> Use saved : there is no button "Column visibility" in the table's pagination toolbar, report groups are displayed like a list and not in tabs Go to Administration -> Columns settings : The selection is not applied Created attachment 73642 [details] [review] Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> I have rebased the patch and would like to ask QA to look at it. I can't reproduce the errors reported in Comment 4, and I think it may have been a browser cache problem. Created attachment 73673 [details] [review] Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works nicely for me, maybe a cache/Plack problem with c#4. I have moved this change to its own bug, bug 20530: - columnname: collection: + columnname: collection To ease backport Pushed to master for 18.05, thanks to everybody involved! (In reply to Lucie Gay from comment #4) > Tested on sandbox Biblibre n°9 > > Go to Reports -> Use saved : > there is no button "Column visibility" in the table's pagination toolbar, > report groups are displayed like a list and not in tabs > > Go to Administration -> Columns settings : > The selection is not applied It was a real bug :) See bug 20814. |