Bug 20814 - Display issue with 'Saved reports' tabs when memcached is off
Summary: Display issue with 'Saved reports' tabs when memcached is off
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 20350
Blocks:
  Show dependency treegraph
 
Reported: 2018-05-24 16:08 UTC by Séverine Queune
Modified: 2019-10-14 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Saved report - bullet list instead of tabs (29.67 KB, image/png)
2018-05-24 16:08 UTC, Séverine Queune
Details
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off (4.66 KB, patch)
2018-05-24 18:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off (4.72 KB, patch)
2018-07-08 16:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off (4.81 KB, patch)
2018-07-13 07:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Séverine Queune 2018-05-24 16:08:08 UTC
Created attachment 75546 [details]
Saved report - bullet list instead of tabs

Saved report tabs become a bullet list when using the search form on /cgi-bin/koha/reports/reports-home.pl
Problem may doesn't appear on some instances, test with sandbox to reproduce (screenshot from Biblibre's sandbox #11).
Comment 1 Owen Leonard 2018-05-24 16:54:48 UTC
The error happens when memcached is disabled. This eliminates the "Cache expiry" column and messes up the column count for DataTAbles.
Comment 2 Owen Leonard 2018-05-24 18:59:12 UTC
Created attachment 75549 [details] [review]
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off

This patch changes the configuration of the saved reports table so that
columns which were previously excluded from the table altogether are now
hidden. This prevents a JavaScript error when DataTables tries to
reference a missing column.

To test, apply the patch and go to Reports -> Use saved. You should have
at least one report category configured and assigned to reports in order
for the tabs display to be visible.

Test the table of saved reports under a variety of these circumstances:

 - memcached disabled or enabled
 - reports exist or don't exist which require update from the old
   marcxml syntax
 - cache_expiry and/or update columns are configured in Administration
   -> Columns settings to be shown or hidden

The report category tabs and the table should render correctly under all
circumstances.
Comment 3 Marcel de Rooy 2018-05-25 07:59:33 UTC
(In reply to Owen Leonard from comment #1)
> The error happens when memcached is disabled. This eliminates the "Cache
> expiry" column and messes up the column count for DataTAbles.

But it should not be disabled now ?
Comment 4 Katrin Fischer 2018-07-08 16:16:29 UTC
Created attachment 76770 [details] [review]
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off

This patch changes the configuration of the saved reports table so that
columns which were previously excluded from the table altogether are now
hidden. This prevents a JavaScript error when DataTables tries to
reference a missing column.

To test, apply the patch and go to Reports -> Use saved. You should have
at least one report category configured and assigned to reports in order
for the tabs display to be visible.

Test the table of saved reports under a variety of these circumstances:

 - memcached disabled or enabled
 - reports exist or don't exist which require update from the old
   marcxml syntax
 - cache_expiry and/or update columns are configured in Administration
   -> Columns settings to be shown or hidden

The report category tabs and the table should render correctly under all
circumstances.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Marcel de Rooy 2018-07-13 07:18:49 UTC
Created attachment 76932 [details] [review]
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off

This patch changes the configuration of the saved reports table so that
columns which were previously excluded from the table altogether are now
hidden. This prevents a JavaScript error when DataTables tries to
reference a missing column.

To test, apply the patch and go to Reports -> Use saved. You should have
at least one report category configured and assigned to reports in order
for the tabs display to be visible.

Test the table of saved reports under a variety of these circumstances:

 - memcached disabled or enabled
 - reports exist or don't exist which require update from the old
   marcxml syntax
 - cache_expiry and/or update columns are configured in Administration
   -> Columns settings to be shown or hidden

The report category tabs and the table should render correctly under all
circumstances.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2018-07-13 07:19:26 UTC
Memcache should not be off anymore, but this does not hurt.
Comment 7 Nick Clemens 2018-07-13 13:48:59 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Martin Renvoize 2018-07-15 20:36:38 UTC
Pushed to 18.05.x for 18.05.02
Comment 9 Fridolin Somers 2018-07-30 14:16:53 UTC Comment hidden (obsolete)
Comment 10 Fridolin Somers 2018-07-30 14:24:13 UTC
Depends on Bug 20350 not in 17.11.x