Summary: | Suggestions: Title Field too small | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Kristina Hoeppner <kristina> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | chris, kristina, mathsabypro, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
placing suggestion - long title
suggested - title cut proposed patch [SIGNED-OFF] Bug 2046 - Suggestions: Title Field too small [PASSED QA] Bug 2046 - Suggestions: Title Field too small screenshot |
Description
Chris Cormack
2010-05-21 00:37:34 UTC
At some point this field was changed back to only 80 characters ... and the text field in the OPAC is limited to only 50 cgi-bin/koha/opac-suggestions.pl?op=add Titles can be very long ... and this 50/80 character limit is too small. Nicole This bug is still valid in master as of 3.12 beta1 This needs a DB upgrade. Will do that with Chris' help later this week. Yay! :) Created attachment 17690 [details] [review] proposed patch Created attachment 17724 [details] [review] [SIGNED-OFF] Bug 2046 - Suggestions: Title Field too small Increase both on staff and OPAC interface from 80 to 255 characters to be saved in the database. Shown will be 80 characters. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 17747 [details] [review] [PASSED QA] Bug 2046 - Suggestions: Title Field too small Increase both on staff and OPAC interface from 80 to 255 characters to be saved in the database. Shown will be 80 characters. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Clean patch, workes as described. To test: - Apply patch and run database update - Check that the column in the database is now varchar(255) - Enter a new suggestion in the OPAC - Edit this suggestion in staff - Confirm form has the new max value set Created attachment 17748 [details]
screenshot
Maybe it would be a bit more visually appealing if we kept the size at 50 but increased the maxsize to new increased value?
This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 *** Bug 10989 has been marked as a duplicate of this bug. *** |