Summary: | Untranslatable strings in circulation statistics | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
Status: | Needs documenting --- | QA Contact: | Aleisha Amohia <aleisha> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, david, f.demians, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes and enhances the circulation statistics report wizard:
- Fixes some strings so that they are now translatable
- Fixes the patron library dropdown list so that it now works
- Improves the "Filtered on" information shown before the report results:
. the filtered on options selected in the report are now shown in bold
. descriptions are now shown instead of codes (for example, the library name instead of the library code)
|
|
Version(s) released in: |
25.11.00,25.05.02
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 40287 | ||
Attachments: |
Bug 20601: Untranslatable strings in circulation statistics
Bug 20601: Untranslatable strings in circulation statistics Bug 20601: Untranslatable strings in circulation statistics |
Description
paxed
2018-04-18 09:49:43 UTC
Created attachment 183626 [details] [review] Bug 20601: Untranslatable strings in circulation statistics This patch makes some updates to the circulation statistics wizard in order to make more information translatable. The patch also adds some template plugins to the output of filter options in order to be able to show descriptions instead of codes, and corrects the markup for the 'Patron library' dropdown which wasn't working. To test apply the patch and go to Reports -> Statistics wizards -> Circulation. - Test setting some or all options in the "Filter column" and running the report. - Confirm that the "Patron library" dropdown works. - At the top of the results there should be a list of the filter options you selected and their values. - All the filter labels should be correct, and the filter values should should be in their full/description form rather than in code form (e.g. library, item type, collection code, sorting field, etc.) Sponsored-by: Athens County Public Libraries Created attachment 183630 [details] [review] Bug 20601: Untranslatable strings in circulation statistics This patch makes some updates to the circulation statistics wizard in order to make more information translatable. The patch also adds some template plugins to the output of filter options in order to be able to show descriptions instead of codes, and corrects the markup for the 'Patron library' dropdown which wasn't working. To test apply the patch and go to Reports -> Statistics wizards -> Circulation. - Test setting some or all options in the "Filter column" and running the report. - Confirm that the "Patron library" dropdown works. - At the top of the results there should be a list of the filter options you selected and their values. - All the filter labels should be correct, and the filter values should should be in their full/description form rather than in code form (e.g. library, item type, collection code, sorting field, etc.) Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 183720 [details] [review] Bug 20601: Untranslatable strings in circulation statistics This patch makes some updates to the circulation statistics wizard in order to make more information translatable. The patch also adds some template plugins to the output of filter options in order to be able to show descriptions instead of codes, and corrects the markup for the 'Patron library' dropdown which wasn't working. To test apply the patch and go to Reports -> Statistics wizards -> Circulation. - Test setting some or all options in the "Filter column" and running the report. - Confirm that the "Patron library" dropdown works. - At the top of the results there should be a list of the filter options you selected and their values. - All the filter labels should be correct, and the filter values should should be in their full/description form rather than in code form (e.g. library, item type, collection code, sorting field, etc.) Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> (In reply to Owen Leonard from comment #1) > - All the filter labels should be correct, and the filter values should > should be in their full/description form rather than in code form > (e.g. library, item type, collection code, sorting field, etc.) > > Sponsored-by: Athens County Public Libraries This is a nice improvement :) Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x I prefer not backport to 24.11.x to avoid translation work and for stability |