The acquisitions, patrons, and catalog circulation statistics wizards have the same translation issues fixed in Bug 20601
Created attachment 184201 [details] [review] Bug 40287: Fix untranslatable strings in more statistics wizards This patch makes some updates to the acquisitions, patrons, and catalog statistics wizards in order to make more information translatable. To test apply the patch and go to Reports. - Under "Statistics wizards," test the acquisitions, patrons, circulation, and catalog statistics reports: - Test setting some or all options in the "Filter column" and running the report. - At the top of the results there should be a list of the filter options you selected and their values. - All the filter labels should be correct, and the filter values should be in their full/description form rather than in code form (e.g. library, item type, collection code, sorting field, etc.) Sponsored-by: Athens County Public Libraries
I think tou are supposed to use GetDescriptionByKohaField. AuthorisedValues.GetByCode( 'CCODE', loopfilte.filter ) => AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => loopfilte.filter ) In case items.ccode would be linked to another AV category than CCODE. Same for LOC, NOT_LOAN, etc.
Created attachment 184451 [details] [review] Bug 40287: (follow-up) Use GetDescriptionByKohaField for item fields