Summary: | Allow separate email configuration for acquisition and serials emails | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Raphael Straub <raphael.straub> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, clemens.tubach, fridolin.somers, martin.renvoize, michaela.sieber, mishravk79, raphael.straub, severine.queune, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18853 |
||
Change sponsored?: | Sponsored | Patch complexity: | Medium patch |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/757 |
Text to go in the release notes: |
This enhancement adds four new system preferences:
- `AcquisitionsDefaultEMailAddress`
- `AcquisitionsDefaultReplyTo`
- `SerialsDefaultEMailAddress`
- `SerialsDefaultReplyTo`
These are used to set specific email addresses to send and receive replies to acquisitions orders notices, late orders claims notices and late serial issues claims notices.
|
Version(s) released in: |
23.11.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35457 | ||
Attachments: |
Bug 20755: Add separate email configuration for acquisition and serial emails
Bug 20755: Add separate email configuration for acquisition and serial emails Bug 20755: Add separate email configuration for acquisition and serial emails Bug 20755: (QA follow-up) Add unit tests Bug 20755: (QA follow-up) Fix capitalization in system preference description Bug 20755: (QA follow-up) Add descriptions to system preferences Bug 20755: Add separate email configuration for acquisition and serial emails Bug 20755: (QA follow-up) Add unit tests Bug 20755: (QA follow-up) Fix capitalization in system preference description Bug 20755: (QA follow-up) Add descriptions to system preferences |
Description
Katrin Fischer
2018-05-11 12:21:33 UTC
We do now use the branch email instead of the librarian's, but it would still be nice to have an option for configuring a separate Acq Team email address to be used. We propose the following new sysprefs: 1.) AcquisitionsDefaultEMailAddress Use the from email address _____ when sending acquisitions order and claim notices. If left empty, it will fall back to the first defined address in the following list: Library email, KohaAdminEmailAddress. 2.) SerialsDefaultEMailAddress Use the from email address _____ when sending serial claim notices. If left empty, it will fall back to the first defined address in the following list: Library email, KohaAdminEmailAddress. 3.) AcquisitionsDefaultReplyTo Use the reply-to email address _____ when sending acquisitions order and claim notices. If left empty, it will fall back to the first defined address in the following list: library ReplyTo, Library email, ReplytoDefault, KohaAdminEmailAddress. 4.) SerialsDefaultReplyTo Use the reply-to email address _____ when sending serial claim notices. If left empty, it will fall back to the first defined address in the following list: library ReplyTo, Library email, ReplytoDefault, KohaAdminEmailAddress. We will provide a path soon, hopefully ;-) Created attachment 157191 [details] [review] Bug 20755: Add separate email configuration for acquisition and serial emails This patch allows every library to define the From and Reply-to email addresses for acquisition and serial emails (orders and claims) sent by Koha. Especially in large libraries with dedicated acquisition departments we need a way that vendors/booksellers can reply directly to the acquisition team and not to the library default email. The library email in the library configuration can then be used for circulation purposes only. 1) Apply patch, run database update 2) Make sure you have set up Koha to send up email (SMTP server, KohaAdminEmailAdress, etc.) 3) Make sure you have a vendor set up with a valid email address. 4) Check that you have four new system preferences: - AcquisitionsDefaultEMailAddress - SerialsDefaultEMailAddress - AcquisitionsDefaultReplyTo - SerialsDefaultReplyTo 5) Check that there is no change in behaviour if the four new system preferences are left empty: All acquisition and serial emails are sent from the library email (or KohaAdminEmailAddress if no library email is set) 6) Create an order with at least one order line. Send the order to your vendor by email. 7) Create an acquisition claim notice and send it to your vendor. 8) Create a subscription linked to your vendor and with at least one late issue. Claim the issue. 9) There should be no change in behaviour: emails should be sent from library email (or KohaAdminEmailAddress if nothing is set on library level) 10) Configure different email addresses for system preferences: - First email address: AcquisitionsDefaultEMailAddress, SerialsDefaultEMailAddress - Second email address: AcquisitionsDefaultReplyTo, SerialsDefaultReplyTo 11) Repeat steps 6-8 12) Verify that the library specific acquisition and serial email addresses are used as From and Reply-to. Sponsored-by: Karlsruhe Institute of Technology (KIT) *** Bug 18853 has been marked as a duplicate of this bug. *** Created attachment 157301 [details] [review] Bug 20755: Add separate email configuration for acquisition and serial emails This patch allows every library to define the From and Reply-to email addresses for acquisition and serial emails (orders and claims) sent by Koha. Especially in large libraries with dedicated acquisition departments we need a way that vendors/booksellers can reply directly to the acquisition team and not to the library default email. The library email in the library configuration can then be used for circulation purposes only. 1) Apply patch, run database update 2) Make sure you have set up Koha to send up email (SMTP server, KohaAdminEmailAdress, etc.) 3) Make sure you have a vendor set up with a valid email address. 4) Check that you have four new system preferences: - AcquisitionsDefaultEMailAddress - SerialsDefaultEMailAddress - AcquisitionsDefaultReplyTo - SerialsDefaultReplyTo 5) Check that there is no change in behaviour if the four new system preferences are left empty: All acquisition and serial emails are sent from the library email (or KohaAdminEmailAddress if no library email is set) 6) Create an order with at least one order line. Send the order to your vendor by email. 7) Create an acquisition claim notice and send it to your vendor. 8) Create a subscription linked to your vendor and with at least one late issue. Claim the issue. 9) There should be no change in behaviour: emails should be sent from library email (or KohaAdminEmailAddress if nothing is set on library level) 10) Configure different email addresses for system preferences: - First email address: AcquisitionsDefaultEMailAddress, SerialsDefaultEMailAddress - Second email address: AcquisitionsDefaultReplyTo, SerialsDefaultReplyTo 11) Repeat steps 6-8 12) Verify that the library specific acquisition and serial email addresses are used as From and Reply-to. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All working great and no regressions found. Signing off. QA note.. we might want some regressions tests here just to ensure the feature isn't broken in a future refactor. Welcome to the team Raphael :) Working on this one and adding some unit tests. Created attachment 157747 [details] [review] Bug 20755: Add separate email configuration for acquisition and serial emails This patch allows every library to define the From and Reply-to email addresses for acquisition and serial emails (orders and claims) sent by Koha. Especially in large libraries with dedicated acquisition departments we need a way that vendors/booksellers can reply directly to the acquisition team and not to the library default email. The library email in the library configuration can then be used for circulation purposes only. 1) Apply patch, run database update 2) Make sure you have set up Koha to send up email (SMTP server, KohaAdminEmailAdress, etc.) 3) Make sure you have a vendor set up with a valid email address. 4) Check that you have four new system preferences: - AcquisitionsDefaultEMailAddress - SerialsDefaultEMailAddress - AcquisitionsDefaultReplyTo - SerialsDefaultReplyTo 5) Check that there is no change in behaviour if the four new system preferences are left empty: All acquisition and serial emails are sent from the library email (or KohaAdminEmailAddress if no library email is set) 6) Create an order with at least one order line. Send the order to your vendor by email. 7) Create an acquisition claim notice and send it to your vendor. 8) Create a subscription linked to your vendor and with at least one late issue. Claim the issue. 9) There should be no change in behaviour: emails should be sent from library email (or KohaAdminEmailAddress if nothing is set on library level) 10) Configure different email addresses for system preferences: - First email address: AcquisitionsDefaultEMailAddress, SerialsDefaultEMailAddress - Second email address: AcquisitionsDefaultReplyTo, SerialsDefaultReplyTo 11) Repeat steps 6-8 12) Verify that the library specific acquisition and serial email addresses are used as From and Reply-to. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 157748 [details] [review] Bug 20755: (QA follow-up) Add unit tests prove t/db_dependent/Letters.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 157749 [details] [review] Bug 20755: (QA follow-up) Fix capitalization in system preference description Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 157771 [details] [review] Bug 20755: (QA follow-up) Add descriptions to system preferences Updates both the atomic update file and the sysprefs.sql with * explanations for each preference * type = "Free" Please rebase ASAP. Thanks! Created attachment 158235 [details] [review] Bug 20755: Add separate email configuration for acquisition and serial emails This patch allows every library to define the From and Reply-to email addresses for acquisition and serial emails (orders and claims) sent by Koha. Especially in large libraries with dedicated acquisition departments we need a way that vendors/booksellers can reply directly to the acquisition team and not to the library default email. The library email in the library configuration can then be used for circulation purposes only. 1) Apply patch, run database update 2) Make sure you have set up Koha to send up email (SMTP server, KohaAdminEmailAdress, etc.) 3) Make sure you have a vendor set up with a valid email address. 4) Check that you have four new system preferences: - AcquisitionsDefaultEMailAddress - SerialsDefaultEMailAddress - AcquisitionsDefaultReplyTo - SerialsDefaultReplyTo 5) Check that there is no change in behaviour if the four new system preferences are left empty: All acquisition and serial emails are sent from the library email (or KohaAdminEmailAddress if no library email is set) 6) Create an order with at least one order line. Send the order to your vendor by email. 7) Create an acquisition claim notice and send it to your vendor. 8) Create a subscription linked to your vendor and with at least one late issue. Claim the issue. 9) There should be no change in behaviour: emails should be sent from library email (or KohaAdminEmailAddress if nothing is set on library level) 10) Configure different email addresses for system preferences: - First email address: AcquisitionsDefaultEMailAddress, SerialsDefaultEMailAddress - Second email address: AcquisitionsDefaultReplyTo, SerialsDefaultReplyTo 11) Repeat steps 6-8 12) Verify that the library specific acquisition and serial email addresses are used as From and Reply-to. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 158236 [details] [review] Bug 20755: (QA follow-up) Add unit tests prove t/db_dependent/Letters.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 158237 [details] [review] Bug 20755: (QA follow-up) Fix capitalization in system preference description Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 158238 [details] [review] Bug 20755: (QA follow-up) Add descriptions to system preferences Updates both the atomic update file and the sysprefs.sql with * explanations for each preference * type = "Free" Easy rebase: There was a new system preference 'SerialsSearchResultsLimit' right before the ones added here. The only conflict was in sysprefs.sql. Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x Is it normal that the Serials system preferences are under Acquisitions preferences? |