Bug 10994 - Allow use of branch/kohaAdmin e-mail address for sending claim notices
Summary: Allow use of branch/kohaAdmin e-mail address for sending claim notices
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Amit Gupta
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 08:47 UTC by Amit Gupta
Modified: 2016-10-02 15:37 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this: 2013-10-28 00:00:00
Who signed the patch off:
Text to go in the release notes:


Attachments
Email sending is not working in claim notice (1014 bytes, patch)
2013-10-07 04:58 UTC, Amit Gupta
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2013-10-04 08:47:03 UTC
From address is null acquisitions claim and serial notice.

my $userenv = C4::Context->userenv;
$userenv->{emailaddress}
Comment 1 Amit Gupta 2013-10-04 08:48:42 UTC
(In reply to Amit from comment #0)
> From address is null acquisitions claim and serial notice.
> 
> my $userenv = C4::Context->userenv;
> $userenv->{emailaddress}

From address contain null value in acquisitions claim and serial notice.
my $userenv = C4::Context->userenv;
$userenv->{emailaddress}
Comment 2 Katrin Fischer 2013-10-04 09:08:25 UTC
It has worked nicely for me in the past - does your staff user have an email address?

I agree that it's unusual for Koha to use the staff patron's email address, so maybe this should only be an option and not the default.
Comment 3 Amit Gupta 2013-10-04 09:24:00 UTC
Hi Katrin,

Yes if staff have an email address claim notice is working fine. But this is not a correct behavior. If we modify the code then it will not check whether staff have email address or not.

my $email_address = $userenv->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress');
Comment 4 Amit Gupta 2013-10-07 04:58:47 UTC
Created attachment 21841 [details] [review]
Email sending is not working in claim notice

Email sending is not working in claim notice.
This patch will not check whether staff patron's email address or not for sending claim notices.
Comment 5 I'm just a bot 2013-10-28 06:25:49 UTC
Patch applied cleanly, go forth and signoff
Comment 6 Chris Cormack 2013-12-22 20:29:34 UTC
This is changing existing behaviour, with no warning, and no option to keep existing behaviour.
Comment 7 Jonathan Druart 2015-02-23 15:59:11 UTC
Amit, do you plan to work again on this one?
Comment 8 Amit Gupta 2015-02-23 16:12:20 UTC
Hi Jonathan Druart,

Yes i have plan will recreate and submit the patch again.
Comment 9 Katrin Fischer 2015-06-07 10:21:04 UTC
As Chris pointed out, we can't change behaviour without warning - best would be to make this optional.
Comment 10 Amit Gupta 2015-06-08 03:28:29 UTC
Thanks Chris & Katrin for suggestion. I will rework & create this feature as a system preference.
Comment 11 Marc Véron 2016-10-02 15:37:37 UTC
Still valid?