|
Description
Owen Leonard
2018-05-18 13:45:52 UTC
Created attachment 75434 [details]
Screenshot of the patron detail page before the patch
Created attachment 75435 [details]
Screenshot of the patron detail page after the patch
Created attachment 75436 [details] [review] Bug 20779 - Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Created attachment 75504 [details] [review] Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> That's a lot of buttons!
Would not it be better to move the "edit" button on the same line as the header block ("Library use", "Alternate address", etc.)?
I like Jonathan's idea I think. Also (if not done already) it would be nice if in the future it would be easier to hide the edit buttons together with the sections. Unwanted fields does not apply to this screen and the buttons always have to be hidden separately. (In reply to Jonathan Druart from comment #5) > That's a lot of buttons! I've gotten feedback from librarians that the edit links were not visible enough. It's clearly an opinion, so we'll need to use our best judgement. > Would not it be better to move the "edit" button on the same line as the > header block ("Library use", "Alternate address", etc.)? The way I have it the edit button appears on the same line as the header if there is no content in the section, and at the bottom if there is. This is my preference, but I'm happy to be outvoted. Created attachment 75628 [details] Screenshot highlighting markup structure. > Also (if not done already) it would be nice if in the future it would be > easier to hide the edit buttons together with the sections. I think I've already done what you're talking about. Maybe we should ask on the list? Created attachment 75638 [details]
Screenshot showing buttons in line with headings
Here is a screenshot of what it might look like with the edit buttons inline with headings.
(In reply to Owen Leonard from comment #10) > Created attachment 75638 [details] > Screenshot showing buttons in line with headings > > Here is a screenshot of what it might look like with the edit buttons inline > with headings. It does make sense to have buttons in sections headings, but then, I would like to see more space before headings, what do you think? Created attachment 75780 [details]
More polished version of buttons in line with headings
(In reply to Owen Leonard from comment #12) > Created attachment 75780 [details] > More polished version of buttons in line with headings That looks great! Created attachment 75855 [details] [review] Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Patch tested with a sandbox, by Cab Vinton <director@plaistowlibrary.com> Created attachment 76968 [details] [review] Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Created attachment 77092 [details] [review] Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |