Bug 20822

Summary: Can't find HOLD_SLIP template when printing
Product: Koha Reporter: Stefan Berndtsson <stefan.berndtsson>
Component: Hold requestsAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart+koha, katrin.fischer, martin.renvoize, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18789    
Bug Blocks:    
Attachments: Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP
Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP
Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

Description Stefan Berndtsson 2018-05-25 14:29:10 UTC
Printing HOLD_SLIP from the Hold found modal can't find the template.

In "returns.tt" the print action is sent "patron.borrowernumber", but the print-slip template parameters in "returns.pl" only include "borrowernumber" and "biblionumber", not "patron".
Comment 1 Jonathan Druart 2018-05-28 18:11:06 UTC
Caused by
  commit ab47e46ea0ade643b308a8b00708d57995c57050
  Bug 18789: Pass a Koha::Patron object from returns.pl
Comment 2 Jonathan Druart 2018-05-28 18:13:06 UTC
Created attachment 75598 [details] [review]
Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

Caused by
  commit ab47e46ea0ade643b308a8b00708d57995c57050
  Bug 18789: Pass a Koha::Patron object from returns.pl

circ/returns.pl does not send a $patron Koha::Patron object to the
template in case print_slip is set

Test plan:
Confirm a hold and print the slip
Comment 3 Katrin Fischer 2018-05-28 20:14:54 UTC
Test plan:
- Place a hold on an item or record
- Return an item to fill the hold
- Check the item in
- Pick "print and confirm"
- Instead of the notice, an error will display in the preview pop-up
Comment 4 Katrin Fischer 2018-05-28 20:23:21 UTC
Created attachment 75610 [details] [review]
Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

Caused by
  commit ab47e46ea0ade643b308a8b00708d57995c57050
  Bug 18789: Pass a Koha::Patron object from returns.pl

circ/returns.pl does not send a $patron Koha::Patron object to the
template in case print_slip is set

Test plan:
Confirm a hold and print the slip

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Chris Cormack 2018-05-28 20:46:46 UTC
Created attachment 75612 [details] [review]
Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

Caused by
  commit ab47e46ea0ade643b308a8b00708d57995c57050
  Bug 18789: Pass a Koha::Patron object from returns.pl

circ/returns.pl does not send a $patron Koha::Patron object to the
template in case print_slip is set

Test plan:
Confirm a hold and print the slip

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 6 Nick Clemens 2018-05-29 14:49:28 UTC
Pushed to master for 18.11.

Awesome work all, thank you.
Comment 7 Martin Renvoize 2018-06-05 09:48:16 UTC
This patch has been pushed to 18.05.x, will be in 18.05.01
Comment 8 Fridolin Somers 2018-06-06 10:01:21 UTC
Depends on Bug 18789 not in 17.11.x