| Summary: | Step 4 of moremember is used for Housebound and additional attributes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, liz, martin.renvoize, nick, oleonard, sandboxes |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 5670, 21085 | ||
| Bug Blocks: | 21209 | ||
| Attachments: |
Bug 20828: Step 4 of moremember is used for Housebound and additional attributes
Bug 20828: Step 4 of moremember is used for Housebound and additional attributes Bug 20828: Step 4 of moremember is used for Housebound and additional attributes |
||
|
Description
Jonathan Druart
2018-05-28 20:41:47 UTC
Not a bug? commit 20c2ea7d3a6e24dd13cf3e6dd47108984852607d Bug 5670: [Followup] Add 'step 4' edit button. Is the bug that there are 2 Edit links for both that lead to the same page? (In reply to Katrin Fischer from comment #2) > Is the bug that there are 2 Edit links for both that lead to the same page? step 4 is used for both housebound module and additional attributes. Created attachment 77139 [details] [review] Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Patch tested with a sandbox, by Cab Vinton <bibliwho@gmail.com> Created attachment 77466 [details] [review] Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> Created attachment 77483 [details] [review] Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03. We don't appear to actually have any direct dependency on bug 21085 here so it works well. Depends on Bug 21085 not in 17.11.x Hi, I think this patchset caused bug 21080 - classes of attributes go outside of the attributes area when HouseBound is disabled. Attributes that have no class are fine. Cheers, Liz |