| Summary: | CSS regressions caused by SCSS move | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | josef.moravec, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19474, 21234, 21237 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 21239: CSS regressions caused by SCSS move
Bug 21239: CSS regressions caused by SCSS move Bug 21239: CSS regressions caused by SCSS move Bug 21239: CSS regressions caused by SCSS move |
||
|
Description
Jonathan Druart
2018-08-16 18:55:07 UTC
Buttons for Datatables Before: https://snag.gy/gMR5US.jpg After : https://snag.gy/hMmZbu.jpg (In reply to Jonathan Druart from comment #1) > .hint Also https://snag.gy/KlPSYp.jpg Mandatory fields Before : https://snag.gy/VhyPXM.jpg After : https://snag.gy/WZdGCM.jpg (In reply to Jonathan Druart from comment #2) > Before: https://snag.gy/gMR5US.jpg > After : https://snag.gy/hMmZbu.jpg Fixed by Bug 21234 Created attachment 77978 [details] [review] Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Created attachment 77985 [details] [review] Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Comment on attachment 77985 [details] [review] Bug 21239: CSS regressions caused by SCSS move Review of attachment 77985 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ +1124,4 @@ > font-weight: bold; > margin-right: 1em; > text-align: right; > + width: 9em; I found this rule when viewing a suggestion: /suggestion/suggestion.pl?suggestionid=1&op=show Applied bug 21234 and bug 21237, but this one conflicts on top: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21239: CSS regressions caused by SCSS move fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Created attachment 78061 [details] [review] Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78102 [details] [review] Bug 21239: CSS regressions caused by SCSS move This patch corrects some mistakes in staff-global.scss made during the conversion from CSS. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. View various forms in the staff client which have hints and required fields, including: - Notices & slips -> Modify notice - Administration -> Budgets -> Modify budget Verify that date format hints are positioned correctly. Try to submit the form with empty required fields and verify that the "This field is required" message is positioned correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Fixes to issues caused by bug 19474 not in 18.05.x series. |
