Bug 21237 - Clean up staff client SCSS
Summary: Clean up staff client SCSS
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 19474
Blocks: 21239
  Show dependency treegraph
 
Reported: 2018-08-16 15:26 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21237: Clean up staff client SCSS (25.72 KB, patch)
2018-08-16 16:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21237: Clean up staff client SCSS (25.81 KB, patch)
2018-08-17 14:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21237: Clean up staff client SCSS (25.79 KB, patch)
2018-08-21 20:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-08-16 15:26:53 UTC
I would like to revise our scss-lint configuration file and make some cleanup changes to staff-global.scss.
Comment 1 Owen Leonard 2018-08-16 16:06:27 UTC
Created attachment 77939 [details] [review]
Bug 21237: Clean up staff client SCSS

This patch removes a redundant linter configuration, .sass-lint.yml,
which was added by mistake.

Some linter rules have been modified to better conform to the defacto
standard set by our existing CSS.

staff-global.scss has been corrected to comply with linter rules
(https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md):

- Comment, style: silent
- TrailingSemicolon, true
- Shorthand
- ColorKeyword, enabled: true
- PropertySortOrder
Comment 2 Jonathan Druart 2018-08-17 14:34:42 UTC
Created attachment 77984 [details] [review]
Bug 21237: Clean up staff client SCSS

This patch removes a redundant linter configuration, .sass-lint.yml,
which was added by mistake.

Some linter rules have been modified to better conform to the defacto
standard set by our existing CSS.

staff-global.scss has been corrected to comply with linter rules
(https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md):

- Comment, style: silent
- TrailingSemicolon, true
- Shorthand
- ColorKeyword, enabled: true
- PropertySortOrder

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Katrin Fischer 2018-08-21 20:38:30 UTC
Created attachment 78055 [details] [review]
Bug 21237: Clean up staff client SCSS

This patch removes a redundant linter configuration, .sass-lint.yml,
which was added by mistake.

Some linter rules have been modified to better conform to the defacto
standard set by our existing CSS.

staff-global.scss has been corrected to comply with linter rules
(https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md):

- Comment, style: silent
- TrailingSemicolon, true
- Shorthand
- ColorKeyword, enabled: true
- PropertySortOrder

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-08-24 16:32:41 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Nick Clemens 2018-08-24 16:34:05 UTC
Katrin, you missed your SO line, and I did too ;-)
Comment 6 Katrin Fischer 2018-08-25 09:21:28 UTC
Ah, sorry, but I meant to!
Comment 7 Martin Renvoize 2018-09-04 11:28:09 UTC
Enhancement will not be backported to 18.05.x series.