Bug 21239 - CSS regressions caused by SCSS move
Summary: CSS regressions caused by SCSS move
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 19474 21234 21237
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-16 18:55 UTC by Jonathan Druart
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21239: CSS regressions caused by SCSS move (2.24 KB, patch)
2018-08-17 13:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21239: CSS regressions caused by SCSS move (2.32 KB, patch)
2018-08-17 14:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21239: CSS regressions caused by SCSS move (2.09 KB, patch)
2018-08-22 00:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21239: CSS regressions caused by SCSS move (2.14 KB, patch)
2018-08-24 01:48 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-08-16 18:55:07 UTC

    
Comment 1 Jonathan Druart 2018-08-16 18:55:35 UTC
.hint
https://snag.gy/yJYbav.jpg
Comment 2 Jonathan Druart 2018-08-16 18:58:49 UTC
Buttons for Datatables

Before: https://snag.gy/gMR5US.jpg
After : https://snag.gy/hMmZbu.jpg
Comment 3 Jonathan Druart 2018-08-16 19:13:45 UTC
(In reply to Jonathan Druart from comment #1)
> .hint

Also https://snag.gy/KlPSYp.jpg
Comment 4 Jonathan Druart 2018-08-16 19:19:10 UTC
Mandatory fields
Before : https://snag.gy/VhyPXM.jpg
After  : https://snag.gy/WZdGCM.jpg
Comment 5 Owen Leonard 2018-08-17 12:00:54 UTC
(In reply to Jonathan Druart from comment #2)
> Before: https://snag.gy/gMR5US.jpg
> After : https://snag.gy/hMmZbu.jpg

Fixed by Bug 21234
Comment 6 Owen Leonard 2018-08-17 13:50:58 UTC
Created attachment 77978 [details] [review]
Bug 21239: CSS regressions caused by SCSS move

This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.
Comment 7 Jonathan Druart 2018-08-17 14:35:05 UTC
Created attachment 77985 [details] [review]
Bug 21239: CSS regressions caused by SCSS move

This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2018-08-17 14:36:15 UTC
Comment on attachment 77985 [details] [review]
Bug 21239: CSS regressions caused by SCSS move

Review of attachment 77985 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
@@ +1124,4 @@
>                  font-weight: bold;
>                  margin-right: 1em;
>                  text-align: right;
> +                width: 9em;

I found this rule when viewing a suggestion: /suggestion/suggestion.pl?suggestionid=1&op=show
Comment 9 Katrin Fischer 2018-08-21 20:13:56 UTC
Applied bug 21234 and bug 21237, but this one conflicts on top:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21239: CSS regressions caused by SCSS move
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Comment 10 Jonathan Druart 2018-08-22 00:30:52 UTC
Created attachment 78061 [details] [review]
Bug 21239: CSS regressions caused by SCSS move

This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Chris Cormack 2018-08-24 01:48:10 UTC
Created attachment 78102 [details] [review]
Bug 21239: CSS regressions caused by SCSS move

This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 12 Nick Clemens 2018-08-24 16:34:31 UTC
Awesome work all!

Pushed to master for 18.11
Comment 13 Martin Renvoize 2018-09-04 11:29:34 UTC
Fixes to issues caused by bug 19474 not in 18.05.x series.