Summary: | Make ILL patron category in koha-conf.xml match with ILL patron category in sample data | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aude.charillon, magnus, martin.renvoize, matt.blenkinsop, Niamh.WalkerHeadon, nick, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Aude Charillon | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/695 |
Text to go in the release notes: |
**Sponsored by** *PTFS Europe*
This makes sure, that in the future the Inter-Library Loan (IL) patron category of the sample data matches the default configuration of the ILL patron category in the `koha-conf.xml` file.
|
Version(s) released in: |
23.05.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 19822, 32911 | ||
Attachments: |
21548: ILLLIBS patron category / partner_code seems extraneous
Bug 21548: ILLLIBS patron category / partner_code seems extraneous Bug 33276: Get auth values for location on serials Bug 21548: ILLLIBS patron category / partner_code seems extraneous |
Description
Andrew Isherwood
2018-10-11 10:18:35 UTC
Hi Andrew, I think using the existing value from the sample data makes sense. But could we make the code configurable? Preferrably moving the current setting out of the conf file and into a pref? That would certainly make sense Katrin, there's quite a bit of the ILL config that would benefit from moving out of koha-conf.xml into sysprefs. Bug 19822 suggests to shift the ILL config from koha-conf.xml to sysprefs. Move to pref and change default to IL are still both great ideas. Created attachment 146333 [details] [review] 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t Created attachment 147416 [details] [review] Bug 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> We should have done this ages ago :) Created attachment 148977 [details] [review] Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 148978 [details] [review] Bug 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x Nice work everyone! Manual will need to be updated. *** Bug 30820 has been marked as a duplicate of this bug. *** 23.05 Manual updated. |