Bug 21548 - Make ILL patron category in koha-conf.xml match with ILL patron category in sample data
Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in s...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
: 30820 (view as bug list)
Depends on:
Blocks: 19822 32911
  Show dependency treegraph
 
Reported: 2018-10-11 10:18 UTC by Andrew Isherwood
Modified: 2023-05-31 15:04 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Aude Charillon
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/695
Text to go in the release notes:
**Sponsored by** *PTFS Europe* This makes sure, that in the future the Inter-Library Loan (IL) patron category of the sample data matches the default configuration of the ILL patron category in the `koha-conf.xml` file.
Version(s) released in:
23.05.00


Attachments
21548: ILLLIBS patron category / partner_code seems extraneous (11.03 KB, patch)
2023-02-07 14:48 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 21548: ILLLIBS patron category / partner_code seems extraneous (11.09 KB, patch)
2023-02-26 10:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33276: Get auth values for location on serials (1.60 KB, patch)
2023-03-30 12:34 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21548: ILLLIBS patron category / partner_code seems extraneous (11.15 KB, patch)
2023-03-30 12:34 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2018-10-11 10:18:35 UTC
The original installation notes created by Alex for ILL (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317#c20) describe a requirement to create a new patron category with a code ILLLIBS, organisational patrons are then attached to this category and their email address is used for the "Place request with partners" function.

However, Koha ships with a patron category called "Inter-Library Loans" (code: IL) which would appear to remove the requirement for an ILLLIBS category to be created.

This bug proposes moving away from using ILLLIBS and using the pre-existing IL category instead. Grepping the code for ILLLIBS reveals that it's assumed to exist and will be used as a default code if one is not specified in the <partner_code> element in koha-conf.xml, so modifications will be required.
Comment 1 Katrin Fischer 2018-10-11 16:43:33 UTC
Hi Andrew, I think using the existing value from the sample data makes sense. But could we make the code configurable? Preferrably moving the current setting out of the conf file and into a pref?
Comment 2 Andrew Isherwood 2018-10-12 10:48:06 UTC
That would certainly make sense Katrin, there's quite a bit of the ILL config that would benefit from moving out of koha-conf.xml into sysprefs.
Comment 3 Magnus Enger 2018-11-06 11:01:37 UTC
Bug 19822 suggests to shift the ILL config from koha-conf.xml to sysprefs.
Comment 4 Katrin Fischer 2023-01-13 10:25:15 UTC
Move to pref and change default to IL are still both great ideas.
Comment 5 Pedro Amorim 2023-02-07 14:48:32 UTC
Created attachment 146333 [details] [review]
21548: ILLLIBS patron category / partner_code seems extraneous

This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml

Preparation:
Apply patch
Enable ILLModule sys pref
Install an ILL backend (e.g. FreeForm)
Add this change to your koha-conf.xml
Flush, restart.
Search for patron of category inter-library loan and assign a primary e-mail address to it

Test plan:
Create an ILL request and click 'place request with partners'
Verify that the 'select partner libraries' has the correct patron of IL category

Run tests and ensure they pass:
prove t/db_dependent/Illrequest/Config.t
prove t/Koha/Config.t
Comment 6 Katrin Fischer 2023-02-26 10:45:27 UTC
Created attachment 147416 [details] [review]
Bug 21548: ILLLIBS patron category / partner_code seems extraneous

This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml

Preparation:
Apply patch
Enable ILLModule sys pref
Install an ILL backend (e.g. FreeForm)
Add this change to your koha-conf.xml
Flush, restart.
Search for patron of category inter-library loan and assign a primary e-mail address to it

Test plan:
Create an ILL request and click 'place request with partners'
Verify that the 'select partner libraries' has the correct patron of IL category

Run tests and ensure they pass:
prove t/db_dependent/Illrequest/Config.t
prove t/Koha/Config.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-02-26 10:46:46 UTC
We should have done this ages ago :)
Comment 8 Nick Clemens 2023-03-30 12:34:33 UTC
Created attachment 148977 [details] [review]
Bug 33276: Get auth values for location on serials

Serial location is linked to a library, if we want to modify serial
with users does not belongs to, location is not in select and we could
erase it.

Test plan:

1) Be sure to have a LOC authorized value limited to one library at
least
2) See when editing serial subscription you didn't get the current
location
3) Apply this patch
4) Refresh and now you've got the value

Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens 2023-03-30 12:34:36 UTC
Created attachment 148978 [details] [review]
Bug 21548: ILLLIBS patron category / partner_code seems extraneous

This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml

Preparation:
Apply patch
Enable ILLModule sys pref
Install an ILL backend (e.g. FreeForm)
Add this change to your koha-conf.xml
Flush, restart.
Search for patron of category inter-library loan and assign a primary e-mail address to it

Test plan:
Create an ILL request and click 'place request with partners'
Verify that the 'select partner libraries' has the correct patron of IL category

Run tests and ensure they pass:
prove t/db_dependent/Illrequest/Config.t
prove t/Koha/Config.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2023-03-31 10:17:26 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Matt Blenkinsop 2023-04-11 11:26:36 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 12 Aude Charillon 2023-05-12 15:32:47 UTC
Manual will need to be updated.
Comment 13 Pedro Amorim 2023-05-18 11:10:29 UTC
*** Bug 30820 has been marked as a duplicate of this bug. ***
Comment 14 Aude Charillon 2023-05-31 15:04:21 UTC
23.05 Manual updated.