Summary: | showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Tools | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, hector.hecaxmmx, jonathan.druart, katrin.fischer, m.de.rooy, marjorie.barry-vila, martin.renvoize, sandboxes, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 21579: Make showdiffmarc.pl work for authorities and biblios
Bug 21579: Make showdiffmarc.pl work for authorities and biblios Bug 21579: Make showdiffmarc.pl work for authorities and biblios Bug 21579: Make showdiffmarc.pl work for authorities and biblios |
Description
Nick Clemens
2018-10-16 14:00:54 UTC
Created attachment 80654 [details] [review] Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Created attachment 80657 [details] [review] Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Signed-off-by: Mark Tompsett <mtompset@hotmail.com> *** Bug 16954 has been marked as a duplicate of this bug. *** Patch tested with a sandbox, by Marjorie Vila <marjorie.barry-vila@collecto.ca> Created attachment 80674 [details] [review] Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> + diff_url => $match_id ? "/cgi-bin/koha/tools/showdiffmarc.pl?batchid=$import_batch_id&importid=$record->{import_record_id}&id=$match_id&type=$record->{record_type}" : undef This is wrong, we should build the URL template-side, but existed prior to this patch. Created attachment 80682 [details] [review] Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Pushed to 17.11.x for 17.11.12 *** Bug 15026 has been marked as a duplicate of this bug. *** |