Description
Margaret Hade
2018-10-24 17:21:55 UTC
Created attachment 82510 [details] [review] Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates *** Bug 21843 has been marked as a duplicate of this bug. *** Created attachment 82570 [details] [review] Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 82571 [details] [review] Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> Created attachment 82572 [details] [review] Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> Signed-off-by: Todd <tgoatley@gmail.com> Created attachment 82597 [details] [review] Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It works, but the code is ugly and hard to maintain. Trivial is not the right qualification if you look for $patron, $newdata etc. in memberentry Awesome work all! Pushed to master for 18.11 Will this be applied to 18.05? This patch does not work for 18.05, not backporting Created attachment 83020 [details] [review] Bug 21649: [18.05.X] Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates (In reply to Nick Clemens from comment #11) > Created attachment 83020 [details] [review] [review] > Bug 21649: [18.05.X] Pass guarantee info to template when adding child > > To test: > 1 - Find an adult patron > 2 - Click 'Add child' > 3 - Note address/phone info does not carry over > 4 - Apply patch > 5 - Repeat > 6 - Note information populates This should be tested - in 18.05 we are creating a new patron object when creating a new one - testing for borrowernumber seems to confirm it is an 'empty' patron and allow for the pass of the guarantor info backported to 18.05 for 18.05.07 Depends on Bug 18789 not in 17.11.x |