|
Description
Josef Moravec
2018-10-26 08:18:48 UTC
Created attachment 81258 [details] [review] Bug 21678: Create account offsets for debits of reserve fee and rental renewal Test plan: 1) Make a reservation to create a reserve fee 2) Have an item type with rental fee and renew it to create rental renewal fe -- without patch there are no entries in table account_offsets for creating a fee -- with patch the appropriate account_offsets are created I agree with the patch. But wouldn't you want to work on Koha::Account::add_debit instead? :-D I think there are plans afoot to add an add_debit method to Koha::Account and this if probably a prime candidate for using that method once it's there.. I'll check in with Tomas on the progress there.. but this patchset could be a good half way house if add_debit is further off than I think. (In reply to Tomás Cohen Arazi from comment #2) > I agree with the patch. But wouldn't you want to work on > Koha::Account::add_debit instead? :-D It would be definitely best solution, but "a bit" more work ;) Can we keep an eye on translation and switch from Reserve to Hold? This bug does not apply, please rebase Initial work on Koha::Account->add_debit now exists if you fancied taking a look and seeing if you could utilise it.. (that work still needs tests and the final coded enums narrowing down) (In reply to Martin Renvoize from comment #7) > Initial work on Koha::Account->add_debit now exists if you fancied taking a > look and seeing if you could utilise it.. (that work still needs tests and > the final coded enums narrowing down) I will try it to use add_debit and we'll see if it suits the needs here Created attachment 81685 [details] [review] Bug 21678: Use Koha::Account->add_debit bug 21720 and 21721 achieve this using add_debit now. bug 21728 too As I'm working through the tree of bugs related to updating all functions to use add_debit from Koha::Accounts (and as part of that trying to fill in the missing tests), I'm going to mark this bug as a duplicate. |