All account handling should go via the Koha::Account class.
Created attachment 81884 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal
Created attachment 81887 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal
Created attachment 81888 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal
Created attachment 83219 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal Known Side Effect: Prior to this patch renewal charges were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_rent`. Sponsored-by: PTFS Europe
Created attachment 84275 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal Known Side Effect: Prior to this patch renewal charges were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_rent`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85529 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal Known Side Effect: Prior to this patch renewal charges were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_rent`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Dependencies pushed to master, yet: error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 21721: Use Koha::Account->add_debit in AddRenewal
Created attachment 86065 [details] [review] Bug 21721: Use Koha::Account->add_debit in AddRenewal Known Side Effect: Prior to this patch renewal charges were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_rent`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Wierd.. I've just rebased my accounts branch and it seems happy.. attached the patch from that https://github.com/PTFS-Europe/koha/compare/master...PTFS-Europe:accounts_all is where I'm tracking this little lot if it helps
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.