For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice.
Created attachment 65769 [details] [review] Bug 19066 - Update Database
Created attachment 65770 [details] [review] Bug 19066 - Update Schema
Created attachment 65771 [details] [review] Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch
*** Bug 7595 has been marked as a duplicate of this bug. ***
Comment on attachment 65771 [details] [review] Bug 19066 - Add branchcode to accountlines Review of attachment 65771 [details] [review]: ----------------------------------------------------------------- Looking for test that triggers "third" part of Circulation.pm changes. prove t/db_dependent/Reserves/ prove t/db_dependent/Accounts.t Just that one little change needs triggering before I'll sign off. Read last Koha/Account comment, then first, then second. ::: C4/Circulation.pm @@ +2872,3 @@ > # Charge a new rental fee, if applicable? > my ( $charge, $type ) = GetIssuingCharges( $itemnumber, $borrowernumber ); > if ( $charge > 0 ) { Do we have a test that triggers this? I haven't found it yet. ::: Koha/Account.pm @@ +69,5 @@ > my $lines = $params->{lines}; > my $type = $params->{type} || 'payment'; > + my $branchcode = $params->{branchcode}; > + > + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; But why line 73 and change the line? @@ +74,2 @@ > > my $userenv = C4::Context->userenv; Why not just after $userenv here, and keep the line identical? @@ -194,5 @@ > note => $note, > } > )->store(); > > - $library_id ||= $userenv ? $userenv->{'branch'} : undef; Yes, this needs to move.
prove -r t/db_dependent fails after applying the patch. Constraint errors related to test builder, I suspect.
(In reply to M. Tompsett from comment #6) > prove -r t/db_dependent fails after applying the patch. Constraint errors > related to test builder, I suspect. Can you please make it explicit what tests are failing? Otherwise its around an hour of waiting for something to fail...
Created attachment 67756 [details] [review] Bug 19066 [QA Followup] - Fix related unit test failures
Created attachment 67757 [details] [review] Bug 19066 [QA Followup] - Fix related unit test failures
Patch doesnt apply for me on master.
Created attachment 71153 [details] [review] Bug 19066 - Update Database
Created attachment 71154 [details] [review] Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch
Created attachment 71155 [details] [review] Bug 19066 - Update Schema
Created attachment 73185 [details] [review] Bug 19066 - Update Database
Created attachment 73186 [details] [review] Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch
Created attachment 73187 [details] [review] Bug 19066 - Update Schema
Comment on attachment 73186 [details] [review] Bug 19066 - Add branchcode to accountlines Review of attachment 73186 [details] [review]: ----------------------------------------------------------------- ::: Koha/Account.pm @@ +76,4 @@ > my $account_type = $params->{account_type}; > my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment'; > > + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; why not below the $userenv below? Less referencing, shorter line, and easier to read. :)
(In reply to M. Tompsett from comment #17) > Comment on attachment 73186 [details] [review] [review] > Bug 19066 - Add branchcode to accountlines > > Review of attachment 73186 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: Koha/Account.pm > @@ +76,4 @@ > > my $account_type = $params->{account_type}; > > my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment'; > > > > + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; > > why not below the $userenv below? Less referencing, shorter line, and easier > to read. :) I'm not sure what you are referencing? Can you point me to the line numbers? Or if you'd rather submit a patch I'd be happy to sign it!
Created attachment 73595 [details] [review] Bug 19066: Follow up to reduce C4::Context references
(In reply to M. Tompsett from comment #19) > Created attachment 73595 [details] [review] [review] > Bug 19066: Follow up to reduce C4::Context references Thanks!
Issue with Sandbox 06 -- Some problems occurred applying patches from bug 19066: <h1>Something went wrong !</h1>Applying: Bug 19066 - Update Database Applying: Bug 19066 - Add branchcode to accountlines .git/rebase-apply/patch:83: trailing whitespace. = C4::Context->userenv->{'number'} if C4::Context->userenv; warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Accounts.pm M C4/Circulation.pm M C4/Reserves.pm M Koha/Account.pm M t/db_dependent/Accounts.t .git/rebase-apply/patch:83: trailing whitespace. = C4::Context->userenv->{'number'} if C4::Context->userenv; warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Accounts.t CONFLICT (content): Merge conflict in t/db_dependent/Accounts.t Auto-merging Koha/Account.pm Auto-merging C4/Reserves.pm Auto-merging C4/Circulation.pm Auto-merging C4/Accounts.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19066 - Add branchcode to accountlines The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 19066 - Add branchcode to accountlines 73185 - Bug 19066 - Update Database 73186 - Bug 19066 - Add branchcode to accountlines 73187 - Bug 19066 - Update Schema 73595 - Bug 19066: Follow up to reduce C4::Context references Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-19066---Add-branchcode-to-accountlines-ArAGEA.patch
Created attachment 77281 [details] [review] Bug 19066: Update Database
Created attachment 77282 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch
Created attachment 77283 [details] [review] Bug 19066: Update Schema
Software error in PTFS Sandbox 0: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.branchcode' in 'field list' at /home/koha/src/Koha/Objects.pm line 209 For help, please send mail to the webmaster (webmaster@ptfs-europe.co.uk), giving this error message and the time and date of the error.
Re-tried & patch applied.
Created attachment 78900 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 78901 [details] [review] Bug 19066: Update Schema Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Please rebase on master Error: CONFLICT (content): Merge conflict in Koha/Schema/Result/Accountline.pm Thank You Mike
Please call it library_id, following the latest use.
Created attachment 81144 [details] [review] Bug 19066: Update Database
Created attachment 81145 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 81146 [details] [review] Bug 19066: Update Schema
Same as bug 21401.
Created attachment 81253 [details] [review] Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 81254 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 81255 [details] [review] Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Tomás Cohen Arazi from comment #30) > Please call it library_id, following the latest use. This has been discussed on bug 21401 comment 14.
Created attachment 81684 [details] [review] Bug 19066: (QA follow-up) Move db update to perl
Hmm.. I'm working on a push to using Koha::Accounts more.. see the graph dangling off bug 21002 . Attempting to rebase my work on top of this I can see at least a couple of places where we're missing things here.. I'm going to set to failed qa whilst I add the followups.
Koha::Account->add_credit isn't handled
Created attachment 81912 [details] [review] Bug 19066: (QA follow-up) Add handling in add_credit
Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and verifying the add_credit use.. do we need to also account for library_id in the API endpoints.
(In reply to Martin Renvoize from comment #43) > Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and > verifying the add_credit use.. do we need to also account for library_id in > the API endpoints. Everything looks correct. But t/db_dependent/Accounts.t is failing.
Created attachment 81918 [details] [review] Bug 19066: (QA follow-up) Remove bad and unecessary test
With Kyle's permission, I'm taking this one. I will complete the tests, so they cover all the changes.
Created attachment 82047 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82048 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82084 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82086 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82087 [details] [review] Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass!
With all the followups this is looking solid to me now.. I'd happily add a second QA stamp to the whole set.
Created attachment 82469 [details] [review] Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82470 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82471 [details] [review] Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82473 [details] [review] Bug 19066: (QA follow-up) Move db update to perl
Created attachment 82474 [details] [review] Bug 19066: (QA follow-up) Add handling in add_credit
Created attachment 82475 [details] [review] Bug 19066: (QA follow-up) Remove bad and unecessary test
Created attachment 82476 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82477 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82478 [details] [review] Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass!
Created attachment 83067 [details] [review] Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 83068 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 83069 [details] [review] Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 83070 [details] [review] Bug 19066: (QA follow-up) Move db update to perl
Created attachment 83071 [details] [review] Bug 19066: (QA follow-up) Add handling in add_credit
Created attachment 83072 [details] [review] Bug 19066: (QA follow-up) Remove bad and unecessary test
Created attachment 83073 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 83074 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 83075 [details] [review] Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass!
Created attachment 83076 [details] [review] Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83077 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83078 [details] [review] Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83079 [details] [review] Bug 19066: (QA follow-up) Move db update to perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83080 [details] [review] Bug 19066: (QA follow-up) Add handling in add_credit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83081 [details] [review] Bug 19066: (QA follow-up) Remove bad and unecessary test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83082 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83083 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83084 [details] [review] Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Rebased, Retested and added my own SO lines as a second more recent QA after the recent changes to master. Did anyone sponsor this work.. there are no 'Sponsored-by' lines ;)
Ack.. yet another thing I've found we've missed... at least it's not pushed yet. Whenever we add a reference like this we really should ensure referential integrity by defining a foreign key constraint. I'll add this to the DB update.
Created attachment 83275 [details] [review] Bug 19066: (QA follow-up) Define foreign key for branchcode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83519 [details] [review] Bug 19066: Update Database Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83520 [details] [review] Bug 19066: Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83521 [details] [review] Bug 19066: Update Schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83522 [details] [review] Bug 19066: (QA follow-up) Move db update to perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83523 [details] [review] Bug 19066: (QA follow-up) Add handling in add_credit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83524 [details] [review] Bug 19066: (QA follow-up) Remove bad and unecessary test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83525 [details] [review] Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83526 [details] [review] Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83527 [details] [review] Bug 19066: Add tests for Koha::Account->pay This patch adds tests for Koha::Account->pay, to make sure the library_id param is used to set the branchcode attribute. The use of userenv to set branchcode if library_id not passed is removed. Responsability is left to the callers to pass library_id. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 83528 [details] [review] Bug 19066: (QA follow-up) Define foreign key for branchcode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Rebased against master
Awesome work all! Pushed to master for 19.05
Created attachment 83628 [details] [review] Bug 19066: (RM follow-up) Fix test count and structure error Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Enhancement, will not be backported to 18.11.x series