Summary: | Localization widget messages are not translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | I18N/L10N | Assignee: | paxed <pasi.kallinen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, m.de.rooy, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 21823 | ||
Bug Blocks: | |||
Attachments: |
Bug 21736: Allow translating the localization widget messages
Bug 21736: Allow translating the localization widget messages Bug 21736: Allow translating the localization widget messages |
Description
paxed
2018-10-31 12:06:34 UTC
Created attachment 81709 [details] [review] Bug 21736: Allow translating the localization widget messages The widget used to translate the item type names to other languages has few javascript messages that cannot be translated. Add the mechanism to enable their translation. Test plan: 1) Install and update a language 2) Check the po-files, there's no msgid for "A translation already exists for this language." 3) Apply the patch 4) Install and update a language 5) There should be a msgid for the one in 2, and couple other messages from localization.tt 6) Translate those messages, update the translated templates 7) Go to Administration -> Item types -> Modify item type -> Translate into other languages Add a new translation, check that the message given by the widget was in correct language. Created attachment 82401 [details] [review] Bug 21736: Allow translating the localization widget messages The widget used to translate the item type names to other languages has few javascript messages that cannot be translated. Add the mechanism to enable their translation. Test plan: 1) Install and update a language 2) Check the po-files, there's no msgid for "A translation already exists for this language." 3) Apply the patch 4) Install and update a language 5) There should be a msgid for the one in 2, and couple other messages from localization.tt 6) Translate those messages, update the translated templates 7) Go to Administration -> Item types -> Modify item type -> Translate into other languages Add a new translation, check that the message given by the widget was in correct language. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> https://bugs.koha-community.org/show_bug.cgi?id=21823 Created attachment 82728 [details] [review] Bug 21736: Allow translating the localization widget messages The widget used to translate the item type names to other languages has few javascript messages that cannot be translated. Add the mechanism to enable their translation. Test plan: 1) Install and update a language 2) Check the po-files, there's no msgid for "A translation already exists for this language." 3) Apply the patch 4) Install and update a language 5) There should be a msgid for the one in 2, and couple other messages from localization.tt 6) Translate those messages, update the translated templates 7) Go to Administration -> Item types -> Modify item type -> Translate into other languages Add a new translation, check that the message given by the widget was in correct language. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work everyone! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.01 |