Bug 21823 - Cannot update or create translations
Summary: Cannot update or create translations
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 15395
Blocks: 21736
  Show dependency treegraph
 
Reported: 2018-11-13 15:36 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2020-01-06 20:15 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 21823: Force creation of POT file even if there is no messages (1.02 KB, patch)
2018-11-13 16:01 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 21823: Force creation of POT file even if there is no messages (1.11 KB, patch)
2018-11-15 08:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21823: Force creation of POT file even if there is no messages (1.14 KB, patch)
2018-11-19 16:06 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2018-11-13 15:36:23 UTC
Bug 15395 broke the translations handling process.
Steps to reproduce:
- Run:
  $ kshell
 k$ cd misc/translator
 k$ perl translate update fr-FR
=> FAIL: You get an error:
system call failed: /bin/sed --in-place /home/vagrant/kohaclone/misc/translator/Koha.pot --expression='s/charset=CHARSET/charset=UTF-8/' at /home/vagrant/kohaclone/misc/translator/LangInstaller.pm line 655.
- Create a new set of language translation files:
 k$ perl translate create xx-YY
=> FAIL: You get an error:
/bin/sed: can't read /home/vagrant/kohaclone/misc/translator/Koha.pot: No such file or directory
system call failed: /bin/sed --in-place /home/vagrant/kohaclone/misc/translator/Koha.pot --expression='s/charset=CHARSET/charset=UTF-8/' at /home/vagrant/kohaclone/misc/translator/LangInstaller.pm line 655.

Note: the translation files get updated/generated, but the error breaks any automatic pipeline.
Comment 1 Julian Maurice 2018-11-13 16:01:05 UTC
Created attachment 82306 [details] [review]
Bug 21823: Force creation of POT file even if there is no messages
Comment 2 Marcel de Rooy 2018-11-15 08:18:19 UTC
Created attachment 82353 [details] [review]
Bug 21823: Force creation of POT file even if there is no messages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Martin Renvoize (ashimema) 2018-11-19 16:06:38 UTC
Created attachment 82518 [details] [review]
Bug 21823: Force creation of POT file even if there is no messages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2018-11-19 16:07:11 UTC
Trivial fix works as expected. Passing QA
Comment 5 Nick Clemens (kidclamp) 2018-11-21 11:36:15 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Jesse Maseto 2018-12-07 18:29:22 UTC
Not able to backport to 18.05.