|
Description
Martin Renvoize (ashimema)
2018-11-01 20:09:25 UTC
Created attachment 81876 [details] [review] Bug 21753: Remove all reference of chargename from scripts Created attachment 81877 [details] [review] Bug 21753: DBRev to remove the field from the database Can you provide a test plan so it will be easy to test and sign it? Thank you. Test Plan Pre-patch: 1) Verify that there is no way to populate this field (short of manually entering data at the command line using SQL) - As far as I can tell, the issuingrules table is always set via the circulation map and there is not option to 'name' each circ rule. Post-patch: 1) Verify that fines are still calculated correctly 2) Verify that all the circulation related tests still pass (or run the entire test suit to be especially sure there are no unseen wider implications) Notes: The field, should it ever have been available for input, would have displayed as part of the fines message in the action logs (if finelogs was turned on) and as part of the textual output if you ran the fines cronjob in verbose mode. However, as it was never filled it obviously wasn't ever output. Hope that helps.. it's hard to come up with a test plan for something that removes a field that was never visible to the end user (or used functionally internally either). Created attachment 82715 [details] [review] [SIGNED-OFF] Bug 21753: Remove all reference of chargename from scripts Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 82716 [details] [review] [SIGNED-OFF] Bug 21753: DBRev to remove the field from the database Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 82730 [details] [review] Bug 21753: Remove all reference of chargename from scripts Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82731 [details] [review] Bug 21753: DBRev to remove the field from the database Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82732 [details] [review] Bug 21753: (QA follow-up) Remove fourth %s in sprintf Trivial. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> @RM: Dont forget DBIx Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. git bisect blames commit aa71519660a43cebc734763e4821818dfc636775 Bug 21753: Remove all reference of chargename from scripts for the following warning from t/db_dependent/Circulation.t: Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. crap.. I missed one.. thanks Jonathan.. I'll add a followup in a new bug. Bug 22374 created |