|
Description
Oliver Behnke
2019-02-05 14:05:52 UTC
FYI, the same should also apply to the self-checkin module (/koha-tmpl/opac-tmpl/bootstrap/css/sci.css), I presume. Created attachment 84809 [details] [review] Crude patch for the SCO module This is a very crude patch for the SCO module. I took the relevant OPAC changes, converted the SCSS to CSS and applied them. Note: it's certainly not meant to be applied as is, as it might still be incomplete or even wrong in places. Yet it should hopefully kickstart and speed up things. Cheers Hi, Thanks for the finding this and working on it. Do you seek tester on this patch? Or do you still need to work on it? Hi Victor, I just uploaded a *crude* patch that was simply meant as a workaround for others having the same problem. It's just a hack that I did to quickly fix our production site. I was hoping that those people responsible for the CSS changes in #20554 or those who developed the SCO/SCI layout would take of this problem and fix it "the right way". That said, I took that patch as far as I could but I wouldn't move that into testing before someone knowledgeable in the area signed off on it, or ideally, fixed/streamlined it first. For instance, I'm not using SCSS which bloats the code and shouldn't be committed that way. Thanks Hi, sorry, it is on my to do list. I was on leave and have a busy couple of weeks coming up but will try and get it done ASAP! Thanks for pointing it out! Hi Claire, I didn't mean to be pushy if I came across like that. Just wanted to clarify any potential misunderstandings :-) Glad to have you back! Cheers Thanks for the clarifications, the "new" status with a patch made me fear that there was a risk being forgotten during many months. But it turns out it's in good hands :) Created attachment 87712 [details] [review] Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Thanks Claire! I'll check it out and get back to you ASAP Created attachment 87779 [details] [review] Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 87780 [details] [review] Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. *** Bug 14000 has been marked as a duplicate of this bug. *** Hi Owen, I tried to test the patches on our local test system and a number of hunks didn't apply. What's the baseline version for the patches? I'm on 18.11.04. Cheers I don't think I can test this properly. The patches are partially rejected on my 18.11.04 test system and I didn't have much luck with various sandboxes either. Either they didn't even get back out of maintenance mode, or I couldn't deploy 22638 and 22274 simulateneously (docker-based SBs / required as they depend on each other) or the patches didn't seem to effective, despite testing 22638 by itself elsewhere did more or less work. Created attachment 88089 [details] [review] Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 88090 [details] [review] Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 88091 [details] [review] Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 88112 [details] [review] Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 88113 [details] [review] Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Thanks everyone for getting this done. Hopefully future OPAC CSS changes will include tests of the SCI/SCO modules as well :-) Cheers! Awesome work all! Pushed to master for 19.05 Bug with enhancement not in 18.11.x series. |